From: Patrick DELAUNAY <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [RESEND PATCH v5 4/4] test: env: add test for env info sub-command
Date: Wed, 24 Jun 2020 07:30:35 +0000 [thread overview]
Message-ID: <e10eedda68bc4b3d9ea86f496561b6fa@SFHDAG6NODE3.st.com> (raw)
In-Reply-To: <8651f65b-88a9-ac03-dab0-16d4f0d161a2@wwwdotorg.org>
Hi Stephen,
> From: Stephen Warren <swarren@wwwdotorg.org>
> Sent: mardi 23 juin 2020 22:25
>
> On 6/23/20 7:25 AM, Patrick DELAUNAY wrote:
> > Hi Stephen,
> >
> >> From: Stephen Warren <swarren@wwwdotorg.org>
> >> Sent: lundi 22 juin 2020 20:51
> >>
> >> On 6/19/20 6:03 AM, Patrick Delaunay wrote:
> >>> Add a pytest for testing the env info sub-command:
> >>>
...
> >
> >>> +def test_env_info(state_test_env):
> >> ...
> >>> + for l in response.split('\n'):
> >>> + if 'env_valid = ' in l:
> >>> + assert '= invalid' in l or '= valid' in l or '= redundant' in l
> >>> + nb_line += 1
> >>> + elif 'env_ready =' in l or 'env_use_default =' in l:
> >>> + assert '= true' in l or '= false' in l
> >>> + nb_line += 1
> >>> + else:
> >>> + assert true
> >>
> >> Those last two lines don't seem terribly useful:-)
> >
> > Not really,
> > beacuse I add the nb_line check,
> > this first check can be removed.
> >
> > Do expect a V6 just for that?
>
> Probably not.
OK I will keep this remark if I need to update the serie
(or the next planned updates of this test)
Patrick
next prev parent reply other threads:[~2020-06-24 7:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 12:03 [RESEND PATCH v5 0/4] cmd: env: add option for quiet output on env info Patrick Delaunay
2020-06-19 12:03 ` [RESEND PATCH v5 1/4] " Patrick Delaunay
2020-06-19 14:51 ` Tom Rini
2020-07-27 13:33 ` Tom Rini
2020-06-19 12:03 ` [RESEND PATCH v5 2/4] cmd: env: check real location for env info command Patrick Delaunay
2020-06-19 14:51 ` Tom Rini
2020-07-27 13:33 ` Tom Rini
2020-06-19 12:03 ` [RESEND PATCH v5 3/4] configs: sandbox: Enable sub command 'env info' Patrick Delaunay
2020-07-27 13:33 ` Tom Rini
2020-06-19 12:03 ` [RESEND PATCH v5 4/4] test: env: add test for env info sub-command Patrick Delaunay
2020-06-22 18:50 ` Stephen Warren
2020-06-23 13:25 ` Patrick DELAUNAY
2020-06-23 20:24 ` Stephen Warren
2020-06-24 7:30 ` Patrick DELAUNAY [this message]
2020-07-27 13:33 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10eedda68bc4b3d9ea86f496561b6fa@SFHDAG6NODE3.st.com \
--to=patrick.delaunay@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox