From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v9] usb: add MediaTek USB3 DRD driver
Date: Thu, 15 Oct 2020 14:28:26 +0200 [thread overview]
Message-ID: <e1736e96-98b1-e4b1-e314-e5119bdba0d8@denx.de> (raw)
In-Reply-To: <1602726548.29336.123.camel@mhfsdcap03>
On 10/15/20 3:49 AM, Chunfeng Yun wrote:
> Hi Marek,
Hi,
> On Wed, 2020-10-14 at 15:03 +0200, Marek Vasut wrote:
>> On 10/14/20 2:29 PM, Chunfeng Yun wrote:
>>> On Wed, 2020-10-14 at 12:56 +0200, Marek Vasut wrote:
>>>> On 10/14/20 10:50 AM, Chunfeng Yun wrote:
>>>>> This patch adds support for the MediaTek USB3 DRD controller,
>>>>> its host side is based on xHCI, this driver supports device mode
>>>>> and host mode.
>>>>
>>>> This patch doesn't seem to apply to u-boot-usb/next ,
> This may cause u-boot-usb/next build error, due to no gadget driver is
> built, because I enabled the following configs in patch 764751784727
> ("configs: mt8512: enable fastboot and USB host related configs"):
> CONFIG_DM_USB_GADGET=y
> CONFIG_USB_MTU3=y
> CONFIG_USB_GADGET=y
>
> but the mtu3 driver is not yet applied in u-boot-usb/next (although
> CONFIG_USB_MTU3 is enabled); and
> CONFIG_DM_USB_GADGET requires a gadget driver to define
> dm_usb_gadget_handle_interrupts(), then the build error happened.
>
>> and also,
>>>> u-boot-usb/next does not build:
>>>
>>> There is error:
>>> aarch64: + mt8512_bm1_emmc
>>> +aarch64-linux-ld.bfd: drivers/usb/gadget/udc/built-in.o: in function
>>> `usb_gadget_handle_interrupts':
>>> +drivers/usb/gadget/udc/udc-uclass.c:56: undefined reference to
>>> `dm_usb_gadget_handle_interrupts'
>>>
>>> It seems that the gadget of mtu3 is not enabled, but the default mode is
>>> gadget mode, not sure why not works.
> I tested it again, and look at the CI pipeline 4997, the mtu3 driver is
> not applied into u-boot-usb/next, so will build error.
>
> Please apply the following patch to u-boot-usb/next, it will build pass:
> https://patchwork.ozlabs.org/project/uboot/patch/1602681717-20850-1-git-send-email-chunfeng.yun at mediatek.com/
> [RESEND,v9] usb: add MediaTek USB3 DRD driver
>
>
> The following patch is not needed anymore, please ignore it
> https://patchwork.ozlabs.org/project/uboot/patch/1602680044-19794-1-git-send-email-chunfeng.yun at mediatek.com/
> [v2] configs: mt8512: enable device mode of mtu3 explicitly
OK, so, please rebase whatever is left on top of usb/next and resend.
This patch does not apply on top of usb/next, sorry.
next prev parent reply other threads:[~2020-10-15 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 8:50 [PATCH v9] usb: add MediaTek USB3 DRD driver Chunfeng Yun
2020-10-14 10:56 ` Marek Vasut
2020-10-14 12:29 ` Chunfeng Yun
2020-10-14 13:03 ` Marek Vasut
2020-10-15 1:49 ` Chunfeng Yun
2020-10-15 12:28 ` Marek Vasut [this message]
2020-10-16 1:43 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1736e96-98b1-e4b1-e314-e5119bdba0d8@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox