From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] socfpga: add support for Terasic DE1-SoC board
Date: Mon, 14 Nov 2016 15:31:13 +0100 [thread overview]
Message-ID: <f18200fc-6174-e74d-1582-d91f2d7cf4d9@denx.de> (raw)
In-Reply-To: <20161114151748.1e3faf3b@crub>
On 11/14/2016 03:17 PM, Anatolij Gustschin wrote:
> Hi,
>
> On Mon, 14 Nov 2016 15:07:31 +0100
> Marek Vasut marex at denx.de wrote:
> ...
>>> +#undef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
>>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION 2
>>
>> Why is this needed ? Just start U-Boot from partition 1 as all the other
>> SoCFPGAs do , esp. since this is a devkit, please keep it consistent.
>
> It is not really needed. I used the original Terasic SD-Card,
> its raw partition is 2. OK, will remove it.
Thanks!
>> Looks great otherwise :)
>
> Thanks for review!
I'll pick V2 for the next release then. Thanks!
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2016-11-14 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 13:53 [U-Boot] [PATCH] socfpga: add support for Terasic DE1-SoC board Anatolij Gustschin
2016-11-14 14:07 ` Marek Vasut
2016-11-14 14:17 ` Anatolij Gustschin
2016-11-14 14:31 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18200fc-6174-e74d-1582-d91f2d7cf4d9@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox