From: Sean Anderson <seanga2@gmail.com>
To: liu.ming50@gmail.com, u-boot@lists.denx.de
Cc: sergio.prado@toradex.com, max.krummenacher@toradex.com,
marcel.ziswiler@toradex.com
Subject: Re: [[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL
Date: Mon, 31 May 2021 10:36:37 -0400 [thread overview]
Message-ID: <f6b37ec8-a3c2-db13-8cd1-9f289c387e7f@gmail.com> (raw)
In-Reply-To: <20210531070620.6780-1-liu.ming50@gmail.com>
On 5/31/21 3:06 AM, liu.ming50@gmail.com wrote:
> From: Ming Liu <liu.ming50@gmail.com>
>
> Only one dtb is currently supported, so match with imx6-colibri.
>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
> board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/board/toradex/colibri_imx6/colibri_imx6.c b/board/toradex/colibri_imx6/colibri_imx6.c
> index c0e7754469..587d92a8e9 100644
> --- a/board/toradex/colibri_imx6/colibri_imx6.c
> +++ b/board/toradex/colibri_imx6/colibri_imx6.c
> @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy)
> board_init_r(NULL, 0);
> }
>
> +#ifdef CONFIG_SPL_LOAD_FIT
> +int board_fit_config_name_match(const char *name)
> +{
> + if (!strcmp(name, "imx6-colibri"))
> + return 0;
> +
> + return -1;
Please use an errno.
> +}
> +#endif
> +
> void reset_cpu(void)
> {
> }
>
Do you need to match "imx6-colibri", or could you use the default config?
--Sean
next prev parent reply other threads:[~2021-05-31 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:06 [[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL liu.ming50
2021-05-31 14:09 ` Marcel Ziswiler
2021-05-31 14:36 ` Sean Anderson [this message]
2021-06-01 15:58 ` Ming Liu
2021-06-02 3:03 ` Sean Anderson
2021-06-01 16:00 ` Ming Liu
-- strict thread matches above, loose matches on Subject: below --
2021-05-30 10:45 liu.ming50
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b37ec8-a3c2-db13-8cd1-9f289c387e7f@gmail.com \
--to=seanga2@gmail.com \
--cc=liu.ming50@gmail.com \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=sergio.prado@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox