public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	u-boot@lists.denx.de
Cc: linux-amarula@amarulasolutions.com, Lukasz Majewski <lukma@denx.de>
Subject: Re: [PATCH 3/3] clk: imx8mn: fix imx8mn_enet_phy_sels clocks list
Date: Wed, 4 Jan 2023 12:27:40 -0500	[thread overview]
Message-ID: <fd6167d7-4f34-392b-46b4-a5afb22b5cdb@gmail.com> (raw)
In-Reply-To: <20221219113127.528282-4-dario.binacchi@amarulasolutions.com>

On 12/19/22 06:31, Dario Binacchi wrote:
> [backport from linux commit 2626cf67f20b28446dfc3a5b9493dd535cdb747b]
> 
> According to the "Clock Root" table of the reference manual (document
> IMX8MNRM Rev 2, 07/2022):
> 
>       Clock Root         offset     Source Select (CCM_TARGET_ROOTn[MUX])
>          ...              ...                    ...
>   ENET_PHY_REF_CLK_ROOT  0xAA80            000 - 24M_REF_CLK
>                                            001 - SYSTEM_PLL2_DIV20
>                                            010 - SYSTEM_PLL2_DIV8
>                                            011 - SYSTEM_PLL2_DIV5
>                                            100 - SYSTEM_PLL2_DIV2
>                                            101 - AUDIO_PLL1_CLK
>                                            110 - VIDEO_PLL_CLK
>                                            111 - AUDIO_PLL2_CLK
>          ...              ...                    ...
> 
> while the imx8mn_enet_phy_sels list didn't contained audio_pll1_out for
> source select bits 101b.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
>   drivers/clk/imx/clk-imx8mn.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index a2c7c63ef74d..692823e74b88 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -41,7 +41,7 @@ static const char *imx8mn_enet_timer_sels[] = {"clock-osc-24m", "sys_pll2_100m",
>   					       "clk_ext3", "clk_ext4", "video_pll_out", };
>   
>   static const char *imx8mn_enet_phy_sels[] = {"clock-osc-24m", "sys_pll2_50m", "sys_pll2_125m", "sys_pll2_200m",
> -					     "sys_pll2_500m", "video_pll_out", "audio_pll2_out", };
> +					     "sys_pll2_500m", "audio_pll1_out", "video_pll_out", "audio_pll2_out", };
>   #endif
>   
>   static const char *imx8mn_nand_usdhc_sels[] = {"clock-osc-24m", "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_200m",

Acked-by: Sean Anderson <seanga2@gmail.com>

  reply	other threads:[~2023-01-04 17:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 11:31 [PATCH 0/3] clk: imx8mn: miscellaneous cleanups and bug fixes Dario Binacchi
2022-12-19 11:31 ` [PATCH 1/3] clk: imx8mn: rename vpu_pll to m7_alt_pll Dario Binacchi
2023-01-04 17:25   ` Sean Anderson
2022-12-19 11:31 ` [PATCH 2/3] clk: imx: rename video_pll1 to video_pll Dario Binacchi
2023-01-04 17:26   ` Sean Anderson
2022-12-19 11:31 ` [PATCH 3/3] clk: imx8mn: fix imx8mn_enet_phy_sels clocks list Dario Binacchi
2023-01-04 17:27   ` Sean Anderson [this message]
2023-01-21 18:16 ` [PATCH 0/3] clk: imx8mn: miscellaneous cleanups and bug fixes Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd6167d7-4f34-392b-46b4-a5afb22b5cdb@gmail.com \
    --to=seanga2@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox