* [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU
@ 2004-02-06 14:13 Thomas Elste
2004-02-10 0:02 ` Wolfgang Denk
2004-02-10 15:33 ` Thomas Elste
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Elste @ 2004-02-06 14:13 UTC (permalink / raw)
To: u-boot
Hi all,
I've ported U-Boot for the ModNET50 board from FSForth. The
board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without
MMU. A patch for this CPU is also included.
The patch is against todays CVS version, I've tested it by
downloading, flashing and booting uCLinux, everything seems
to work fine. If nevertheless anything is wrong with the code,
please let me know.
best regards
Thomas
--
Thomas Elste
Institut fuer Mikroelektronik- und Mechatronik-Systeme
www.imms.de
Langewiesener Strasse 22
98693 Ilmenau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-modnet50.patch.bz2
Type: application/bzip2
Size: 25581 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040206/de837a86/attachment.bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU
2004-02-06 14:13 [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU Thomas Elste
@ 2004-02-10 0:02 ` Wolfgang Denk
2004-02-10 15:33 ` Thomas Elste
1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2004-02-10 0:02 UTC (permalink / raw)
To: u-boot
In message <opr2ycf4kg940igx@smtp.elste.org> you wrote:
>
> I've ported U-Boot for the ModNET50 board from FSForth. The
> board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without
> MMU. A patch for this CPU is also included.
At first glance I see little difference between your code in
cpu/netarm and what we already have in cpu/arm720t - and nothing that
could not be implemente dby a few #ifdef's.
Why do you think this is a so different type of CPU that we will need
a new CPU directory?
If possible, I would like to avoid creating a new CPU directory which
just duplicates existing code.
> The patch is against todays CVS version, I've tested it by
> downloading, flashing and booting uCLinux, everything seems
> to work fine. If nevertheless anything is wrong with the code,
> please let me know.
In the meantime I added the patch which changed the ARM memory
layout. This obsoletes your patch.
I'm afraid I have to ask you to resubmit this patch.
Best regards,
Wolfgang Denk
--
See us @ Embedded World, Nuremberg, Feb 17 - 19, Hall 12.0 Booth 440
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
Nothing is easier than to denounce the evildoer; nothing is more
difficult than to understand him. - Fyodor Dostoevski
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU
2004-02-06 14:13 [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU Thomas Elste
2004-02-10 0:02 ` Wolfgang Denk
@ 2004-02-10 15:33 ` Thomas Elste
2004-02-23 19:30 ` Wolfgang Denk
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Elste @ 2004-02-10 15:33 UTC (permalink / raw)
To: u-boot
>> I've ported U-Boot for the ModNET50 board from FSForth. The
>> board uses a NET+50 CPU from Netsilicon, an ARM7TDMI without
>> MMU. A patch for this CPU is also included.
> If possible, I would like to avoid creating a new CPU directory which
> just duplicates existing code.
Ok, I've changed the layout, so that the arm720t cpu directory
is used. The serial i/o stuff differs a lot, so I've created a
new file: serial_netarm.c . Anything else is done by ifdefs now.
> In the meantime I added the patch which changed the ARM memory
> layout. This obsoletes your patch.
> I'm afraid I have to ask you to resubmit this patch.
No problem, here's the new one (against todays CVS).
best regards
Thomas
--
Thomas Elste
Institut fuer Mikroelektronik- und Mechatronik-Systeme
www.imms.de
Langewiesener Strasse 22
98693 Ilmenau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-modnet50.diff.bz2
Type: application/bzip2
Size: 21906 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040210/4e7d819f/attachment.bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU
2004-02-10 15:33 ` Thomas Elste
@ 2004-02-23 19:30 ` Wolfgang Denk
[not found] ` <opr3valsnmzmlzqt@smtp.web.de>
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2004-02-23 19:30 UTC (permalink / raw)
To: u-boot
In message <opr25utze9940igx@smtp.elste.org> you wrote:
>
> Ok, I've changed the layout, so that the arm720t cpu directory
> is used. The serial i/o stuff differs a lot, so I've created a
> new file: serial_netarm.c . Anything else is done by ifdefs now.
Thanks, added.
I moved some files around to avoid having architecture specific files
in the common include/ directory.
Also, I had to cleanup you code a lot - next time please check
section "Coding Style" in the README.
Please also submit another patch to add the required entries to the
MAINTAINERS and CREDITS files.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
"No one talks peace unless he's ready to back it up with war."
"He talks of peace if it is the only way to live."
-- Colonel Green and Surak of Vulcan, "The Savage Curtain",
stardate 5906.5.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-02-26 23:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-06 14:13 [U-Boot-Users] Patch for ModNET50 board and NET+50 CPU Thomas Elste
2004-02-10 0:02 ` Wolfgang Denk
2004-02-10 15:33 ` Thomas Elste
2004-02-23 19:30 ` Wolfgang Denk
[not found] ` <opr3valsnmzmlzqt@smtp.web.de>
2004-02-24 13:39 ` Thomas Elste
2004-02-26 23:19 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox