From: Ferass El Hafidi <funderscore@postmarketos.org>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Kory Maincent (TI.com) <kory.maincent@bootlin.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Anshul Dalal <anshuld@ti.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Martin Schwan <m.schwan@phytec.de>,
David Zang <davidzangcs@gmail.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
Date: Sat, 11 Apr 2026 14:47:00 +0000 [thread overview]
Message-ID: <tdc3t2.1tjebl3bs6nc5@postmarketos.org> (raw)
In-Reply-To: <CAFLszTgvueYQUyGCQp3amZN20__LMvz_Eu5S_m=OQf9QDsr+DQ@mail.gmail.com>
Hi Simon,
On Sat, 11 Apr 2026 13:34, Simon Glass <sjg@chromium.org> wrote:
>Hi,
>
>On Sat, 11 Apr 2026 at 07:27, Simon Glass <sjg@chromium.org> wrote:
>>
>> On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
>> > autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
>> >
>> > The autoboot prompt used to only be customizable in Kconfig when
>> > AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
>> > autoboot prompt alongside a splash screen, there is no reason for
>> > AUTOBOOT_KEYED to be required for this.
>> >
>> > Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
>> > print_boot_delay() instead of a hardcoded string.
>> >
>> > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>> > Reviewed-by: Tom Rini <trini@konsulko.com>
>> >
>> > boot/Kconfig | 30 +++++++++++++++---------------
>> > common/autoboot.c | 2 +-
>> > 2 files changed, 16 insertions(+), 16 deletions(-)
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>
>Actually doc/README.autoboot documents CONFIG_AUTOBOOT_PROMPT as part
>of the CONFIG_AUTOBOOT_KEYED group. [...]
Sure can!
>[...] Since you are decoupling these,
>please can you add a patch to update the documentation? Really it
>should move to doc/ though, if you have the energy for that.
>
It's already in doc/, what do you mean by that?
Best regards,
Ferass
next prev parent reply other threads:[~2026-04-11 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 16:34 [PATCH v2 0/2] Autoboot prompt customization and bootmenu cosmetics Ferass El Hafidi
2026-04-08 16:34 ` [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED Ferass El Hafidi
2026-04-08 16:51 ` Tom Rini
2026-04-11 13:27 ` Simon Glass
2026-04-11 13:34 ` Simon Glass
2026-04-11 14:47 ` Ferass El Hafidi [this message]
2026-04-11 14:53 ` Tom Rini
2026-04-11 14:56 ` Ferass El Hafidi
2026-04-08 16:34 ` [PATCH v2 2/2] cmd: bootmenu: ANSI_CLEAR_LINE before entry name Ferass El Hafidi
2026-04-11 13:34 ` Simon Glass
2026-04-15 15:43 ` [PATCH v2 0/2] Autoboot prompt customization and bootmenu cosmetics Ferass El Hafidi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tdc3t2.1tjebl3bs6nc5@postmarketos.org \
--to=funderscore@postmarketos.org \
--cc=anshuld@ti.com \
--cc=ansuelsmth@gmail.com \
--cc=davidzangcs@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=m.schwan@phytec.de \
--cc=mkorpershoek@kernel.org \
--cc=quentin.schulz@cherry.de \
--cc=semen.protsenko@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox