Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]

On Sat, Apr 11, 2026 at 02:47:00PM +0000, Ferass El Hafidi wrote:
> Hi Simon,
> 
> On Sat, 11 Apr 2026 13:34, Simon Glass <sjg@chromium.org> wrote:
> > Hi,
> > 
> > On Sat, 11 Apr 2026 at 07:27, Simon Glass <sjg@chromium.org> wrote:
> > > 
> > > On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
> > > > autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
> > > >
> > > > The autoboot prompt used to only be customizable in Kconfig when
> > > > AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
> > > > autoboot prompt alongside a splash screen, there is no reason for
> > > > AUTOBOOT_KEYED to be required for this.
> > > >
> > > > Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
> > > > print_boot_delay() instead of a hardcoded string.
> > > >
> > > > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
> > > > Reviewed-by: Tom Rini <trini@konsulko.com>
> > > >
> > > > boot/Kconfig      | 30 +++++++++++++++---------------
> > > >  common/autoboot.c |  2 +-
> > > >  2 files changed, 16 insertions(+), 16 deletions(-)
> > > 
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > 
> > Actually doc/README.autoboot documents CONFIG_AUTOBOOT_PROMPT as part
> > of the CONFIG_AUTOBOOT_KEYED group. [...]
> 
> Sure can!
> 
> > [...] Since you are decoupling these,
> > please can you add a patch to update the documentation? Really it
> > should move to doc/ though, if you have the energy for that.
> > 
> 
> It's already in doc/, what do you mean by that?

It should be in rST and part of our public docs, rather than a plain
text file under doc/.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]