[PATCH v2 0/2] Autoboot prompt customization and bootmenu cosmetics

[PATCH v2 0/2] Autoboot prompt customization and bootmenu cosmetics

[Ferass El Hafidi]

This is a small patch series to make the autoboot prompt configurable
regardless of if CONFIG_AUTOBOOT_KEYED is enabled, which is very useful
with a splash screen. My usecase is, with some ANSI magic, moving the
autoboot prompt to the very bottom of the screen and highlighted, with a
splash screen shown.
Something like this: https://ircb.dersco.re/uploads/funderscore/efa2a27132e56891
It feels wrong to require AUTOBOOT_KEYED only for that usecase.

Also, the bootmenu now prints ANSI_CLEAR_LINE before each entry, which
has the effect of highlighting the entire line entry on vidconsole, just
like eficonfig. I can drop that one if it's not very useful, just
thought it would look nice.

Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
---
Changes in v2:
 - Remove #ifdef/#endif near printf in print_boot_delay: no need to
   guard the printf as CONFIG_AUTOBOOT_PROMPT must be set
 - Link to v1: https://lore.kernel.org/r/20260405-ui-cosmetics-v1-0-bffec3cac741@postmarketos.org

---
Ferass El Hafidi (2):
      autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
      cmd: bootmenu: ANSI_CLEAR_LINE before entry name

 boot/Kconfig      | 30 +++++++++++++++---------------
 cmd/bootmenu.c    |  2 +-
 common/autoboot.c |  2 +-
 3 files changed, 17 insertions(+), 17 deletions(-)
---
base-commit: 0da1866a8fdd4d4bc4837ef2af281dbe010ae16b
change-id: 20260331-ui-cosmetics-aae207abed6b

Best regards,
-- 
Ferass El Hafidi <funderscore@postmarketos.org>

[PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Ferass El Hafidi]

The autoboot prompt used to only be customizable in Kconfig when
AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
autoboot prompt alongside a splash screen, there is no reason for
AUTOBOOT_KEYED to be required for this.

Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
print_boot_delay() instead of a hardcoded string.

Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
---
 boot/Kconfig      | 30 +++++++++++++++---------------
 common/autoboot.c |  2 +-
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/boot/Kconfig b/boot/Kconfig
index bfed452d77e..039c5acc023 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -1560,6 +1560,21 @@ config AUTOBOOT
 	help
 	  This enables the autoboot.  See doc/README.autoboot for detail.
 
+config AUTOBOOT_PROMPT
+	string "Autoboot stop prompt"
+	default "Autoboot in %d seconds\\n" if AUTOBOOT_KEYED
+	default "\\rHit any key to stop autoboot: %d"
+	help
+	  This string is displayed before the boot delay selected by
+	  CONFIG_BOOTDELAY starts.
+
+	  Note that this define is used as the (only) argument to a
+	  printf() call, so it may contain '%' format specifications,
+	  provided that it also includes, separated by commas exactly
+	  like in a printf statement, the required arguments. It is
+	  the responsibility of the user to select only such arguments
+	  that are valid in the given context.
+
 if AUTOBOOT
 
 config BOOTDELAY
@@ -1597,21 +1612,6 @@ config AUTOBOOT_FLUSH_STDIN
 	  This can't be enabled for the sandbox as flushing stdin would
 	  break the autoboot unit tests.
 
-config AUTOBOOT_PROMPT
-	string "Autoboot stop prompt"
-	default "Autoboot in %d seconds\\n"
-	help
-	  This string is displayed before the boot delay selected by
-	  CONFIG_BOOTDELAY starts. If it is not defined	there is no
-	  output indicating that autoboot is in progress.
-
-	  Note that this define is used as the (only) argument to a
-	  printf() call, so it may contain '%' format specifications,
-	  provided that it also includes, separated by commas exactly
-	  like in a printf statement, the required arguments. It is
-	  the responsibility of the user to select only such arguments
-	  that are valid in the given context.
-
 config AUTOBOOT_ENCRYPTION
 	bool "Enable encryption in autoboot stopping"
 	help
diff --git a/common/autoboot.c b/common/autoboot.c
index 1783ef92c94..7114ee58f47 100644
--- a/common/autoboot.c
+++ b/common/autoboot.c
@@ -379,7 +379,7 @@ static int abortboot_key_sequence(int bootdelay)
 
 static void print_boot_delay(int bootdelay)
 {
-	printf(ANSI_CLEAR_LINE "\rHit any key to stop autoboot: %d", bootdelay);
+	printf(ANSI_CLEAR_LINE CONFIG_AUTOBOOT_PROMPT, bootdelay);
 }
 
 static int abortboot_single_key(int bootdelay)

-- 
2.53.0

Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Wed, Apr 08, 2026 at 04:34:56PM +0000, Ferass El Hafidi wrote:

> The autoboot prompt used to only be customizable in Kconfig when
> AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
> autoboot prompt alongside a splash screen, there is no reason for
> AUTOBOOT_KEYED to be required for this.
> 
> Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
> print_boot_delay() instead of a hardcoded string.
> 
> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Simon Glass]

On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
> autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
>
> The autoboot prompt used to only be customizable in Kconfig when
> AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
> autoboot prompt alongside a splash screen, there is no reason for
> AUTOBOOT_KEYED to be required for this.
>
> Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
> print_boot_delay() instead of a hardcoded string.
>
> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> boot/Kconfig      | 30 +++++++++++++++---------------
>  common/autoboot.c |  2 +-
>  2 files changed, 16 insertions(+), 16 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Simon Glass]

Hi,

On Sat, 11 Apr 2026 at 07:27, Simon Glass <sjg@chromium.org> wrote:
>
> On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
> > autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
> >
> > The autoboot prompt used to only be customizable in Kconfig when
> > AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
> > autoboot prompt alongside a splash screen, there is no reason for
> > AUTOBOOT_KEYED to be required for this.
> >
> > Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
> > print_boot_delay() instead of a hardcoded string.
> >
> > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> > boot/Kconfig      | 30 +++++++++++++++---------------
> >  common/autoboot.c |  2 +-
> >  2 files changed, 16 insertions(+), 16 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Actually doc/README.autoboot documents CONFIG_AUTOBOOT_PROMPT as part
of the CONFIG_AUTOBOOT_KEYED group. Since you are decoupling these,
please can you add a patch to update the documentation? Really it
should move to doc/ though, if you have the energy for that.

Regards,
Simon

Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Ferass El Hafidi]

Hi Simon,

On Sat, 11 Apr 2026 13:34, Simon Glass <sjg@chromium.org> wrote:
>Hi,
>
>On Sat, 11 Apr 2026 at 07:27, Simon Glass <sjg@chromium.org> wrote:
>>
>> On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
>> > autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
>> >
>> > The autoboot prompt used to only be customizable in Kconfig when
>> > AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
>> > autoboot prompt alongside a splash screen, there is no reason for
>> > AUTOBOOT_KEYED to be required for this.
>> >
>> > Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
>> > print_boot_delay() instead of a hardcoded string.
>> >
>> > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>> > Reviewed-by: Tom Rini <trini@konsulko.com>
>> >
>> > boot/Kconfig      | 30 +++++++++++++++---------------
>> >  common/autoboot.c |  2 +-
>> >  2 files changed, 16 insertions(+), 16 deletions(-)
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>
>Actually doc/README.autoboot documents CONFIG_AUTOBOOT_PROMPT as part
>of the CONFIG_AUTOBOOT_KEYED group. [...]

Sure can!

>[...] Since you are decoupling these,
>please can you add a patch to update the documentation? Really it
>should move to doc/ though, if you have the energy for that.
>

It's already in doc/, what do you mean by that?

Best regards,
Ferass

Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]

On Sat, Apr 11, 2026 at 02:47:00PM +0000, Ferass El Hafidi wrote:
> Hi Simon,
> 
> On Sat, 11 Apr 2026 13:34, Simon Glass <sjg@chromium.org> wrote:
> > Hi,
> > 
> > On Sat, 11 Apr 2026 at 07:27, Simon Glass <sjg@chromium.org> wrote:
> > > 
> > > On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
> > > > autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
> > > >
> > > > The autoboot prompt used to only be customizable in Kconfig when
> > > > AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
> > > > autoboot prompt alongside a splash screen, there is no reason for
> > > > AUTOBOOT_KEYED to be required for this.
> > > >
> > > > Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
> > > > print_boot_delay() instead of a hardcoded string.
> > > >
> > > > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
> > > > Reviewed-by: Tom Rini <trini@konsulko.com>
> > > >
> > > > boot/Kconfig      | 30 +++++++++++++++---------------
> > > >  common/autoboot.c |  2 +-
> > > >  2 files changed, 16 insertions(+), 16 deletions(-)
> > > 
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > 
> > Actually doc/README.autoboot documents CONFIG_AUTOBOOT_PROMPT as part
> > of the CONFIG_AUTOBOOT_KEYED group. [...]
> 
> Sure can!
> 
> > [...] Since you are decoupling these,
> > please can you add a patch to update the documentation? Really it
> > should move to doc/ though, if you have the energy for that.
> > 
> 
> It's already in doc/, what do you mean by that?

It should be in rST and part of our public docs, rather than a plain
text file under doc/.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] autoboot: allow custom prompt without requiring AUTOBOOT_KEYED

[Ferass El Hafidi]

On Sat, 11 Apr 2026 14:53, Tom Rini <trini@konsulko.com> wrote:
>On Sat, Apr 11, 2026 at 02:47:00PM +0000, Ferass El Hafidi wrote:
>> Hi Simon,
>> 
>> On Sat, 11 Apr 2026 13:34, Simon Glass <sjg@chromium.org> wrote:
>> > Hi,
>> > 
>> > On Sat, 11 Apr 2026 at 07:27, Simon Glass <sjg@chromium.org> wrote:
>> > > 
>> > > On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
>> > > > autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
>> > > >
>> > > > The autoboot prompt used to only be customizable in Kconfig when
>> > > > AUTOBOOT_KEYED was enabled. For a usecase such as having a nicer
>> > > > autoboot prompt alongside a splash screen, there is no reason for
>> > > > AUTOBOOT_KEYED to be required for this.
>> > > >
>> > > > Remove the dependency to AUTOBOOT_KEYED, and use AUTOBOOT_PROMPT in
>> > > > print_boot_delay() instead of a hardcoded string.
>> > > >
>> > > > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>> > > > Reviewed-by: Tom Rini <trini@konsulko.com>
>> > > >
>> > > > boot/Kconfig      | 30 +++++++++++++++---------------
>> > > >  common/autoboot.c |  2 +-
>> > > >  2 files changed, 16 insertions(+), 16 deletions(-)
>> > > 
>> > > Reviewed-by: Simon Glass <sjg@chromium.org>
>> > 
>> > Actually doc/README.autoboot documents CONFIG_AUTOBOOT_PROMPT as part
>> > of the CONFIG_AUTOBOOT_KEYED group. [...]
>> 
>> Sure can!
>> 
>> > [...] Since you are decoupling these,
>> > please can you add a patch to update the documentation? Really it
>> > should move to doc/ though, if you have the energy for that.
>> > 
>> 
>> It's already in doc/, what do you mean by that?
>
>It should be in rST and part of our public docs, rather than a plain
>text file under doc/.
>

Ah right, sure can do that too.

Best regards,
Ferass

[PATCH v2 2/2] cmd: bootmenu: ANSI_CLEAR_LINE before entry name

[Ferass El Hafidi]

This has the effect of highlighting the whole entry when it is selected
(on vidconsole), which makes it consistent with eficonfig too.

Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
---
 cmd/bootmenu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/bootmenu.c b/cmd/bootmenu.c
index d3108778c6f..a07fea49322 100644
--- a/cmd/bootmenu.c
+++ b/cmd/bootmenu.c
@@ -76,7 +76,7 @@ static void bootmenu_print_entry(void *data)
 	if (reverse)
 		puts(ANSI_COLOR_REVERSE);
 
-	printf("%s", entry->title);
+	printf(ANSI_CLEAR_LINE "%s", entry->title);
 
 	if (reverse)
 		puts(ANSI_COLOR_RESET);

-- 
2.53.0

Re: [PATCH v2 2/2] cmd: bootmenu: ANSI_CLEAR_LINE before entry name

[Simon Glass]

On 2026-04-08T16:34:55, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
> cmd: bootmenu: ANSI_CLEAR_LINE before entry name
>
> This has the effect of highlighting the whole entry when it is selected
> (on vidconsole), which makes it consistent with eficonfig too.
>
> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>
> cmd/bootmenu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH v2 0/2] Autoboot prompt customization and bootmenu cosmetics

[Ferass El Hafidi]

Thank you all for your review, I sent a v3 which is mostly untouched,
but adds a patch to convert docs to reStructuredText.

On Wed, 08 Apr 2026 16:34, Ferass El Hafidi <funderscore@postmarketos.org> wrote:
>This is a small patch series to make the autoboot prompt configurable
>regardless of if CONFIG_AUTOBOOT_KEYED is enabled, which is very useful
>with a splash screen. My usecase is, with some ANSI magic, moving the
>autoboot prompt to the very bottom of the screen and highlighted, with a
>splash screen shown.
>Something like this: https://ircb.dersco.re/uploads/funderscore/efa2a27132e56891
>It feels wrong to require AUTOBOOT_KEYED only for that usecase.
>
>Also, the bootmenu now prints ANSI_CLEAR_LINE before each entry, which
>has the effect of highlighting the entire line entry on vidconsole, just
>like eficonfig. I can drop that one if it's not very useful, just
>thought it would look nice.
>
>Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>---
>Changes in v2:
> - Remove #ifdef/#endif near printf in print_boot_delay: no need to
>   guard the printf as CONFIG_AUTOBOOT_PROMPT must be set
> - Link to v1: https://lore.kernel.org/r/20260405-ui-cosmetics-v1-0-bffec3cac741@postmarketos.org
>
>---
>Ferass El Hafidi (2):
>      autoboot: allow custom prompt without requiring AUTOBOOT_KEYED
>      cmd: bootmenu: ANSI_CLEAR_LINE before entry name
>
> boot/Kconfig      | 30 +++++++++++++++---------------
> cmd/bootmenu.c    |  2 +-
> common/autoboot.c |  2 +-
> 3 files changed, 17 insertions(+), 17 deletions(-)
>---
>base-commit: 0da1866a8fdd4d4bc4837ef2af281dbe010ae16b
>change-id: 20260331-ui-cosmetics-aae207abed6b


Best regards,
Ferass