From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH] wdctl: align with other util-linux commands
Date: Thu, 19 Apr 2012 21:10:54 +0200 [thread overview]
Message-ID: <1334862654-32253-1-git-send-email-kerolasa@iki.fi> (raw)
* Add watchdog device path to pathnames.h
* Check output stream status at exit.
* Adjust usage() notation to follow howto file.
* Retire numeric return value.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
include/pathnames.h | 2 ++
sys-utils/wdctl.c | 10 +++++++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/include/pathnames.h b/include/pathnames.h
index 88bec08..ba8de01 100644
--- a/include/pathnames.h
+++ b/include/pathnames.h
@@ -146,6 +146,8 @@
/* deprecated */
#define _PATH_RAWDEVCTL_OLD "/dev/rawctl"
+/* wdctl path */
+#define _PATH_WATCHDOG_DEV "/dev/watchdog"
#endif /* PATHNAMES_H */
diff --git a/sys-utils/wdctl.c b/sys-utils/wdctl.c
index 179aff2..4c6f874 100644
--- a/sys-utils/wdctl.c
+++ b/sys-utils/wdctl.c
@@ -28,6 +28,8 @@
#include "nls.h"
#include "c.h"
+#include "closestream.h"
+#include "pathnames.h"
static const struct {
uint32_t flag;
@@ -55,7 +57,8 @@ static void usage(int status)
_(" %s [options]\n"), program_invocation_short_name);
fputs(USAGE_OPTIONS, out);
- fputs(_(" -d, --device= device to use (/dev/watchdog)\n"), out);
+ fprintf(out,
+ _(" -d, --device <path> device to use (default is %s)\n"), _PATH_WATCHDOG_DEV);
fputs(USAGE_SEPARATOR, out);
fputs(USAGE_HELP, out);
@@ -94,12 +97,13 @@ int main(int argc, char *argv[])
};
int c, status, sec, fd;
- const char *device = "/dev/watchdog";
+ const char *device = _PATH_WATCHDOG_DEV;
struct watchdog_info ident;
setlocale(LC_MESSAGES, "");
bindtextdomain(PACKAGE, LOCALEDIR);
textdomain(PACKAGE);
+ atexit(close_stdout);
while((c = getopt_long(argc, argv, "hVd:", longopts, NULL)) != -1) {
@@ -176,5 +180,5 @@ int main(int argc, char *argv[])
close(fd);
- return 0;
+ return EXIT_SUCCESS;
}
--
1.7.10
next reply other threads:[~2012-04-19 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 19:10 Sami Kerola [this message]
2012-05-02 17:37 ` [PATCH] wdctl: align with other util-linux commands Sami Kerola
2012-05-03 6:39 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334862654-32253-1-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox