From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] wdctl: align with other util-linux commands
Date: Thu, 3 May 2012 08:39:19 +0200 [thread overview]
Message-ID: <20120503063919.GC16016@x2.net.home> (raw)
In-Reply-To: <CAG27Bk3B3J456tO8s+vk0mGvAVns_nVkHVH8KdAeb7nvkkc7ng@mail.gmail.com>
On Wed, May 02, 2012 at 07:37:55PM +0200, Sami Kerola wrote:
> On Thu, Apr 19, 2012 at 9:10 PM, Sami Kerola <kerolasa@iki.fi> wrote:
> > * Add watchdog device path to pathnames.h
> > * Check output stream status at exit.
> > * Adjust usage() notation to follow howto file.
> > * Retire numeric return value.
> >
> > include/pathnames.h | 2 ++
> > sys-utils/wdctl.c | 10 +++++++---
> > 2 files changed, 9 insertions(+), 3 deletions(-)
>
> Hi Karel,
>
> It's been while since I sent this to review. Perhaps it is soon time
> to accept or reject the patch.
Good timing, I'm just working on the code ;-)
Sorry for the delay, your changes seems correct, but I'd like to a
little rewrite the original Lennart's code to to make it more
compatible with our new utils (like lsblk, lslocks, ...).
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-05-03 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 19:10 [PATCH] wdctl: align with other util-linux commands Sami Kerola
2012-05-02 17:37 ` Sami Kerola
2012-05-03 6:39 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503063919.GC16016@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox