* [PATCH 1/5] fdisk: remove unused hsc2sector macro
@ 2012-05-06 12:10 Davidlohr Bueso
2012-05-06 17:34 ` Petr Uzel
0 siblings, 1 reply; 4+ messages in thread
From: Davidlohr Bueso @ 2012-05-06 12:10 UTC (permalink / raw)
To: Karel Zak, Petr Uzel; +Cc: util-linux
From: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
fdisk/fdisk.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fdisk/fdisk.c b/fdisk/fdisk.c
index dccaf27..3543745 100644
--- a/fdisk/fdisk.c
+++ b/fdisk/fdisk.c
@@ -68,8 +68,6 @@ int MBRbuffer_changed;
#define sector(s) ((s) & 0x3f)
#define cylinder(s, c) ((c) | (((s) & 0xc0) << 2))
-#define hsc2sector(h,s,c) (sector(s) - 1 + sectors * \
- ((h) + heads * cylinder(s,c)))
#define set_hsc(h,s,c,sector) { \
s = sector % sectors + 1; \
sector /= sectors; \
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] fdisk: remove unused hsc2sector macro
2012-05-06 12:10 [PATCH 1/5] fdisk: remove unused hsc2sector macro Davidlohr Bueso
@ 2012-05-06 17:34 ` Petr Uzel
2012-05-06 18:53 ` Davidlohr Bueso
0 siblings, 1 reply; 4+ messages in thread
From: Petr Uzel @ 2012-05-06 17:34 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: util-linux
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Sun, May 06, 2012 at 02:10:16PM +0200, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> fdisk/fdisk.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fdisk/fdisk.c b/fdisk/fdisk.c
> index dccaf27..3543745 100644
> --- a/fdisk/fdisk.c
> +++ b/fdisk/fdisk.c
> @@ -68,8 +68,6 @@ int MBRbuffer_changed;
> #define sector(s) ((s) & 0x3f)
> #define cylinder(s, c) ((c) | (((s) & 0xc0) << 2))
>
> -#define hsc2sector(h,s,c) (sector(s) - 1 + sectors * \
> - ((h) + heads * cylinder(s,c)))
> #define set_hsc(h,s,c,sector) { \
> s = sector % sectors + 1; \
> sector /= sectors; \
This patch seems to be malformed. Could you please check what's wrong?
Thanks,
Petr
--
Petr Uzel
IRC: ptr_uzl @ freenode
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] fdisk: remove unused hsc2sector macro
2012-05-06 17:34 ` Petr Uzel
@ 2012-05-06 18:53 ` Davidlohr Bueso
2012-05-10 9:46 ` Karel Zak
0 siblings, 1 reply; 4+ messages in thread
From: Davidlohr Bueso @ 2012-05-06 18:53 UTC (permalink / raw)
To: Petr Uzel; +Cc: util-linux
On Sun, 2012-05-06 at 19:34 +0200, Petr Uzel wrote:
> On Sun, May 06, 2012 at 02:10:16PM +0200, Davidlohr Bueso wrote:
> > From: Davidlohr Bueso <dave@gnu.org>
> >
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > ---
> > fdisk/fdisk.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/fdisk/fdisk.c b/fdisk/fdisk.c
> > index dccaf27..3543745 100644
> > --- a/fdisk/fdisk.c
> > +++ b/fdisk/fdisk.c
> > @@ -68,8 +68,6 @@ int MBRbuffer_changed;
> > #define sector(s) ((s) & 0x3f)
> > #define cylinder(s, c) ((c) | (((s) & 0xc0) << 2))
> >
> > -#define hsc2sector(h,s,c) (sector(s) - 1 + sectors * \
> > - ((h) + heads * cylinder(s,c)))
> > #define set_hsc(h,s,c,sector) { \
> > s = sector % sectors + 1; \
> > sector /= sectors; \
>
> This patch seems to be malformed. Could you please check what's wrong?
Hmm perhaps my mail client did something stupid (or me :)
From: Davidlohr Bueso <dave@gnu.org>
Date: Sun, 6 May 2012 20:51:37 +0200
Subject: [PATCH] fdisk: remove unused hsc2sector-macor
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
fdisk/fdisk.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fdisk/fdisk.c b/fdisk/fdisk.c
index dccaf27..3543745 100644
--- a/fdisk/fdisk.c
+++ b/fdisk/fdisk.c
@@ -68,8 +68,6 @@ int MBRbuffer_changed;
#define sector(s) ((s) & 0x3f)
#define cylinder(s, c) ((c) | (((s) & 0xc0) << 2))
-#define hsc2sector(h,s,c) (sector(s) - 1 + sectors * \
- ((h) + heads * cylinder(s,c)))
#define set_hsc(h,s,c,sector) { \
s = sector % sectors + 1; \
sector /= sectors; \
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] fdisk: remove unused hsc2sector macro
2012-05-06 18:53 ` Davidlohr Bueso
@ 2012-05-10 9:46 ` Karel Zak
0 siblings, 0 replies; 4+ messages in thread
From: Karel Zak @ 2012-05-10 9:46 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: Petr Uzel, util-linux
On Sun, May 06, 2012 at 08:53:14PM +0200, Davidlohr Bueso wrote:
> fdisk/fdisk.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-10 9:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-06 12:10 [PATCH 1/5] fdisk: remove unused hsc2sector macro Davidlohr Bueso
2012-05-06 17:34 ` Petr Uzel
2012-05-06 18:53 ` Davidlohr Bueso
2012-05-10 9:46 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox