From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 2/7] kill: remove unnecessary indirection
Date: Sat, 12 Apr 2014 11:28:39 +0100 [thread overview]
Message-ID: <1397298524-3364-3-git-send-email-kerolasa@iki.fi> (raw)
In-Reply-To: <1397298524-3364-1-git-send-email-kerolasa@iki.fi>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
misc-utils/kill.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/misc-utils/kill.c b/misc-utils/kill.c
index e678661..9566f14 100644
--- a/misc-utils/kill.c
+++ b/misc-utils/kill.c
@@ -434,8 +434,6 @@ static char **parse_arguments(int argc, char **argv, struct kill_control *ctl)
}
if (!*argv)
errx(EXIT_FAILURE, _("not enough arguments"));
- if (ctl->do_pid)
- ctl->numsig = -1;
return argv;
}
@@ -444,7 +442,7 @@ static int kill_verbose(const struct kill_control *ctl)
{
int rc = 0;
- if (ctl->numsig < 0) {
+ if (ctl->do_pid) {
printf("%ld\n", (long) ctl->pid);
return 0;
}
--
1.9.2
next prev parent reply other threads:[~2014-04-12 10:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 10:28 [PATCH 0/7] kill: add regression tests Sami Kerola
2014-04-12 10:28 ` [PATCH 1/7] kill: make options --pid and --queue mutually exclusive Sami Kerola
2014-04-12 15:57 ` Bernhard Voelker
2014-04-12 16:35 ` Sami Kerola
2014-04-12 10:28 ` Sami Kerola [this message]
2014-04-12 10:28 ` [PATCH 3/7] tests: add signal receiver program Sami Kerola
2014-04-12 10:28 ` [PATCH 4/7] tests: check kill is converting signals names correctly Sami Kerola
2014-04-13 22:22 ` Bernhard Voelker
2014-04-14 7:42 ` Sami Kerola
2014-04-14 15:13 ` Sami Kerola
2014-04-14 16:14 ` Bernhard Voelker
2014-04-14 19:00 ` Sami Kerola
2014-04-15 9:09 ` Bernhard Voelker
2014-04-15 11:08 ` Sami Kerola
2014-04-12 10:28 ` [PATCH 5/7] tests: check various ways to specify kill signal Sami Kerola
2014-04-12 10:28 ` [PATCH 6/7] tests: check kill print pid option Sami Kerola
2014-04-12 10:28 ` [PATCH 7/7] tests: check kill all user processes Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397298524-3364-3-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox