Re: [PATCH 4/7] tests: check kill is converting signals names correctly

[Bernhard Voelker <mail@bernhard-voelker.de>]

On 04/14/2014 05:13 PM, Sami Kerola wrote:
> Here is new set of tests, and they almost work.
>
> https://github.com/kerolasa/lelux-utiliteetit/tree/kill-tests-v2
>
> The 'name_to_number' check[1] is giving random errors, and my wooden
> eyes does not observe where is the problem. Or if the problem is in
> kill itself, and random errors are a real bug. According to helper
> witness file the signal receiver is running, but kill does not find
> it. Some times the check passes without issues, but more often there
> is one that kind of error, sometime two.
>
> [1] https://github.com/kerolasa/lelux-utiliteetit/commit/516fa50baa0daf764a53063e44163e1c3328e110
>
> Ideas, comments, help!

Hi Sami,

thanks.

Looking quickly at the tests, I think I don't understand the idea behind
all that symlinking stuff. I mean for most test cases it would suffice
to kill with the PID instead of the process name.

Re. the test failures of name_to_number: when I change the kill command
to work on $TEST_PID instead of the symlink name, then I don't get the
failures anymore.

BTW: is there a reason why you stick to using $(jobs -p) to get the
TEST_PID instead of the much simpler "$!"?

Thanks & have a nice day,
Berny