From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 12/12] lib/pager: use names when referring to standard file descriptors
Date: Sun, 27 Apr 2014 21:05:38 +0100 [thread overview]
Message-ID: <1398629138-31718-13-git-send-email-kerolasa@iki.fi> (raw)
In-Reply-To: <1398629138-31718-1-git-send-email-kerolasa@iki.fi>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
| 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--git a/lib/pager.c b/lib/pager.c
index c6e74e8..9e09cd5 100644
--- a/lib/pager.c
+++ b/lib/pager.c
@@ -63,10 +63,10 @@ static int start_command(struct child_process *cmd)
cmd->pid = fork();
if (!cmd->pid) {
if (need_in) {
- dup2(fdin[0], 0);
+ dup2(fdin[0], STDIN_FILENO);
close_pair(fdin);
} else if (cmd->in > 0) {
- dup2(cmd->in, 0);
+ dup2(cmd->in, STDIN_FILENO);
close(cmd->in);
}
@@ -134,7 +134,7 @@ static void pager_preexec(void)
fd_set in;
FD_ZERO(&in);
- FD_SET(0, &in);
+ FD_SET(STDIN_FILENO, &in);
select(1, &in, NULL, &in, NULL);
setenv("LESS", "FRSX", 0);
@@ -145,8 +145,8 @@ static void wait_for_pager(void)
fflush(stdout);
fflush(stderr);
/* signal EOF to pager */
- close(1);
- close(2);
+ close(STDOUT_FILENO);
+ close(STDERR_FILENO);
finish_command(&pager_process);
}
@@ -160,7 +160,7 @@ void setup_pager(void)
{
const char *pager = getenv("PAGER");
- if (!isatty(1))
+ if (!isatty(STDOUT_FILENO))
return;
if (!pager)
@@ -178,9 +178,9 @@ void setup_pager(void)
return;
/* original process continues, but writes to the pipe */
- dup2(pager_process.in, 1);
- if (isatty(2))
- dup2(pager_process.in, 2);
+ dup2(pager_process.in, STDOUT_FILENO);
+ if (isatty(STDERR_FILENO))
+ dup2(pager_process.in, STDERR_FILENO);
close(pager_process.in);
/* this makes sure that the parent terminates after the pager */
--
1.9.2
next prev parent reply other threads:[~2014-04-27 20:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 20:05 [PATCH 00/12] pull: mostly swap command clarifications Sami Kerola
2014-04-27 20:05 ` [PATCH 01/12] include/xalloc: ensure arithmetics overflow cannot happen Sami Kerola
2014-04-27 20:45 ` Bernhard Voelker
2014-04-28 6:52 ` Karel Zak
2014-04-28 8:42 ` Sami Kerola
2014-04-27 20:05 ` [PATCH 02/12] dmesg: move get_boot_time() to lib/timeutils Sami Kerola
2014-05-06 10:00 ` Ruediger Meier
2014-05-06 11:20 ` Karel Zak
2014-05-06 13:42 ` Ruediger Meier
2014-05-06 14:40 ` Karel Zak
2014-05-06 16:03 ` Ruediger Meier
2014-05-07 9:52 ` Karel Zak
2014-05-07 14:04 ` Ruediger Meier
2014-04-27 20:05 ` [PATCH 03/12] last: fix is_phantom() detection Sami Kerola
2014-04-27 20:05 ` [PATCH 04/12] include/c.h: add macro to print definitions as string Sami Kerola
2014-04-27 20:05 ` [PATCH 05/12] mkswap, swaplabel: move version number to header Sami Kerola
2014-04-27 20:05 ` [PATCH 06/12] mkswap: remove legacy swap structure Sami Kerola
2014-04-27 20:05 ` [PATCH 07/12] include/swapheader.h: ensure type sizes Sami Kerola
2014-04-27 20:05 ` [PATCH 08/12] swapon: swaps with legacy version label are not supported Sami Kerola
2014-04-28 8:37 ` Benno Schulenberg
2014-04-28 8:44 ` Sami Kerola
2014-04-28 9:00 ` Karel Zak
2014-04-27 20:05 ` [PATCH 09/12] swapon, swapheader, mkswap: move swap signature to header Sami Kerola
2014-04-27 20:05 ` [PATCH 10/12] libsmartcols: remove ununsed assignment Sami Kerola
2014-04-28 9:02 ` Karel Zak
2014-04-27 20:05 ` [PATCH 11/12] lib/timeutils: fix memory leak Sami Kerola
2014-04-27 20:05 ` Sami Kerola [this message]
2014-04-29 21:05 ` [PATCH 00/12] pull: mostly swap command clarifications Sami Kerola
2014-04-29 21:46 ` Bernhard Voelker
2014-05-06 8:36 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398629138-31718-13-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox