From: Karel Zak <kzak@redhat.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: Sami Kerola <kerolasa@iki.fi>, util-linux@vger.kernel.org
Subject: Re: [PATCH 02/12] dmesg: move get_boot_time() to lib/timeutils
Date: Tue, 6 May 2014 13:20:54 +0200 [thread overview]
Message-ID: <20140506112054.GP5962@x2.net.home> (raw)
In-Reply-To: <201405061200.00836.sweet_f_a@gmx.de>
On Tue, May 06, 2014 at 12:00:00PM +0200, Ruediger Meier wrote:
> On Sunday 27 April 2014, Sami Kerola wrote:
> > In future the last(1) will use get_boot_time() as well.
> >
> > Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> > ---
> > include/timeutils.h | 1 +
> > lib/timeutils.c | 29 +++++++++++++++++++++++++++++
> > sys-utils/dmesg.c | 27 ---------------------------
> > 3 files changed, 30 insertions(+), 27 deletions(-)
> >
> > [...]
> > -
> > -#ifdef CLOCK_BOOTTIME
> > - if (clock_gettime(CLOCK_BOOTTIME, &hires_uptime) == 0) {
> > - TIMESPEC_TO_TIMEVAL(&lores_uptime, &hires_uptime);
> > - timersub(&now, &lores_uptime, boot_time);
> > - return 0;
> > - }
>
> clock_gettime() needs -lrt on some systems. That's why we had
> dmesg_LDADD += -lrt. Now every binary which links against libcommon
> needs that.
Fixed, I have moved get_boot_time() outside libcommon. The question
is how portable will be last(1), maybe it will necessary to add
something like "if HAVE_LIBRT" to the build system, now there is
hardcoded -lrt.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-05-06 11:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 20:05 [PATCH 00/12] pull: mostly swap command clarifications Sami Kerola
2014-04-27 20:05 ` [PATCH 01/12] include/xalloc: ensure arithmetics overflow cannot happen Sami Kerola
2014-04-27 20:45 ` Bernhard Voelker
2014-04-28 6:52 ` Karel Zak
2014-04-28 8:42 ` Sami Kerola
2014-04-27 20:05 ` [PATCH 02/12] dmesg: move get_boot_time() to lib/timeutils Sami Kerola
2014-05-06 10:00 ` Ruediger Meier
2014-05-06 11:20 ` Karel Zak [this message]
2014-05-06 13:42 ` Ruediger Meier
2014-05-06 14:40 ` Karel Zak
2014-05-06 16:03 ` Ruediger Meier
2014-05-07 9:52 ` Karel Zak
2014-05-07 14:04 ` Ruediger Meier
2014-04-27 20:05 ` [PATCH 03/12] last: fix is_phantom() detection Sami Kerola
2014-04-27 20:05 ` [PATCH 04/12] include/c.h: add macro to print definitions as string Sami Kerola
2014-04-27 20:05 ` [PATCH 05/12] mkswap, swaplabel: move version number to header Sami Kerola
2014-04-27 20:05 ` [PATCH 06/12] mkswap: remove legacy swap structure Sami Kerola
2014-04-27 20:05 ` [PATCH 07/12] include/swapheader.h: ensure type sizes Sami Kerola
2014-04-27 20:05 ` [PATCH 08/12] swapon: swaps with legacy version label are not supported Sami Kerola
2014-04-28 8:37 ` Benno Schulenberg
2014-04-28 8:44 ` Sami Kerola
2014-04-28 9:00 ` Karel Zak
2014-04-27 20:05 ` [PATCH 09/12] swapon, swapheader, mkswap: move swap signature to header Sami Kerola
2014-04-27 20:05 ` [PATCH 10/12] libsmartcols: remove ununsed assignment Sami Kerola
2014-04-28 9:02 ` Karel Zak
2014-04-27 20:05 ` [PATCH 11/12] lib/timeutils: fix memory leak Sami Kerola
2014-04-27 20:05 ` [PATCH 12/12] lib/pager: use names when referring to standard file descriptors Sami Kerola
2014-04-29 21:05 ` [PATCH 00/12] pull: mostly swap command clarifications Sami Kerola
2014-04-29 21:46 ` Bernhard Voelker
2014-05-06 8:36 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506112054.GP5962@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox