From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 14/15] cytune: use matching type in struct cyclades_control with kernel
Date: Sun, 4 May 2014 16:49:55 +0100 [thread overview]
Message-ID: <1399218596-21321-15-git-send-email-kerolasa@iki.fi> (raw)
In-Reply-To: <1399218596-21321-1-git-send-email-kerolasa@iki.fi>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
sys-utils/cytune.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/sys-utils/cytune.c b/sys-utils/cytune.c
index c93951d..d9bc900 100644
--- a/sys-utils/cytune.c
+++ b/sys-utils/cytune.c
@@ -62,7 +62,7 @@ struct cyclades_control {
struct cyclades_monitor c;
char *filename;
int cfile;
- int maxmax;
+ unsigned long maxmax;
double maxtran;
unsigned long threshold_value;
unsigned long timeout_value;
@@ -132,7 +132,7 @@ signal_handler(int sig __attribute__((__unused__)))
for (i = local_optind; i < argc; i++, j++) {
cc = &cmon[j];
- warnx(_("File %s, For threshold value %lu, Maximum characters in fifo were %d,\n"
+ warnx(_("File %s, For threshold value %lu, Maximum characters in fifo were %lu,\n"
"and the maximum transfer rate in characters/second was %f"),
cc->filename, cc->threshold_value, cc->maxmax, cc->maxtran);
}
@@ -143,7 +143,7 @@ signal_handler(int sig __attribute__((__unused__)))
static void print_statistics(struct cyclades_control *cc, int init)
{
if (0 < cc->threshold_value && !init)
- warnx(_("File %s, For threshold value %lu and timeout value %lu, Maximum characters in fifo were %d,\n"
+ warnx(_("File %s, For threshold value %lu and timeout value %lu, Maximum characters in fifo were %lu,\n"
"and the maximum transfer rate in characters/second was %f"),
cc->filename, cc->threshold_value, cc->timeout_value, cc->maxmax, cc->maxtran);
cc->maxmax = 0;
@@ -221,8 +221,7 @@ query_tty_stats(int argc, char **argv, struct cytune_modifiers *mod)
/* Don't record this first cycle after change */
if (cc->maxtran < xfer_rate)
cc->maxtran = xfer_rate;
- if (cc->maxmax < 0 ||
- (unsigned long)cc->maxmax < cywork.char_max)
+ if (cc->maxmax < cywork.char_max)
cc->maxmax = cywork.char_max;
}
printf(_("%s: %lu ints, %lu chars; fifo: %lu thresh, %lu tmout, "
--
1.9.2
next prev parent reply other threads:[~2014-05-04 15:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 15:49 [PATCH 00/15] cytune modernization Sami Kerola
2014-05-04 15:49 ` [PATCH 01/15] cytune: rename threshold and timeout variables Sami Kerola
2014-05-05 8:34 ` Benno Schulenberg
2014-05-04 15:49 ` [PATCH 02/15] cytune: remove unnecessary variables Sami Kerola
2014-05-05 8:29 ` Benno Schulenberg
2014-05-04 15:49 ` [PATCH 03/15] cytune: be consistent with interval data type Sami Kerola
2014-05-04 15:49 ` [PATCH 04/15] cytune: use single loop for setting and getting ioctl() calls Sami Kerola
2014-05-05 8:24 ` Benno Schulenberg
2014-05-04 15:49 ` [PATCH 05/15] cytune: kernel still does not have send_count in cyclades_monitor structure Sami Kerola
2014-05-04 15:49 ` [PATCH 06/15] cytune: prefer sigaction(), and remove unnecessary abstractions Sami Kerola
2014-05-04 15:49 ` [PATCH 07/15] cytune: add cyg_get_mon() to avoid duplicate code Sami Kerola
2014-05-04 15:49 ` [PATCH 08/15] cytune: add structure to hold run time configuration Sami Kerola
2014-05-04 15:49 ` [PATCH 09/15] cytune: pull signal handling and statistic priting apart Sami Kerola
2014-05-04 15:49 ` [PATCH 10/15] cytune: remove unnecessary type casts Sami Kerola
2014-05-04 15:49 ` [PATCH 11/15] cytune: deprecate undescriptive options Sami Kerola
2014-05-04 15:49 ` [PATCH 12/15] cytune: add filename to struct cyclades_control Sami Kerola
2014-05-04 15:49 ` [PATCH 13/15] cytune: add noreturn function attributes Sami Kerola
2014-05-04 15:49 ` Sami Kerola [this message]
2014-05-04 15:49 ` [PATCH 15/15] cytune: update copyright Sami Kerola
2014-05-07 7:10 ` [PATCH 00/15] cytune modernization Karel Zak
2014-05-07 8:12 ` Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399218596-21321-15-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox