From: Benno Schulenberg <bensberg@justemail.net>
To: Sami Kerola <kerolasa@iki.fi>
Cc: "Util-Linux" <util-linux@vger.kernel.org>
Subject: Re: [PATCH 01/15] cytune: rename threshold and timeout variables
Date: Mon, 05 May 2014 10:34:38 +0200 [thread overview]
Message-ID: <1399278878.12657.113701373.0499DDA9@webmail.messagingengine.com> (raw)
In-Reply-To: <1399218596-21321-2-git-send-email-kerolasa@iki.fi>
On Sun, May 4, 2014, at 17:49, Sami Kerola wrote:
> + threshold_def_val = strtou32_or_err(optarg,
> + _("Invalid threshold default value"));
> + if (threshold_def_val < 0 || 12 < threshold_def_val) {
> + warnx(_("Invalid threshold default value: %d"),
Again, swap "threshold" and "default".
> + _("Invalid set timeout value"));
> + if (timeout_val < 1 || 255 < timeout_val) {
> + warnx(_("Invalid set timeout value: %d"),
> + timeout_val);
s/set//
> + _("Invalid default timeout value"));
> + if (timeout_def_val < 0 || 255 < timeout_def_val) {
> warnx(_("Invalid default time value: %d"),
s/time/timeout/
Benno
--
http://www.fastmail.fm - The professional email service
next prev parent reply other threads:[~2014-05-05 8:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 15:49 [PATCH 00/15] cytune modernization Sami Kerola
2014-05-04 15:49 ` [PATCH 01/15] cytune: rename threshold and timeout variables Sami Kerola
2014-05-05 8:34 ` Benno Schulenberg [this message]
2014-05-04 15:49 ` [PATCH 02/15] cytune: remove unnecessary variables Sami Kerola
2014-05-05 8:29 ` Benno Schulenberg
2014-05-04 15:49 ` [PATCH 03/15] cytune: be consistent with interval data type Sami Kerola
2014-05-04 15:49 ` [PATCH 04/15] cytune: use single loop for setting and getting ioctl() calls Sami Kerola
2014-05-05 8:24 ` Benno Schulenberg
2014-05-04 15:49 ` [PATCH 05/15] cytune: kernel still does not have send_count in cyclades_monitor structure Sami Kerola
2014-05-04 15:49 ` [PATCH 06/15] cytune: prefer sigaction(), and remove unnecessary abstractions Sami Kerola
2014-05-04 15:49 ` [PATCH 07/15] cytune: add cyg_get_mon() to avoid duplicate code Sami Kerola
2014-05-04 15:49 ` [PATCH 08/15] cytune: add structure to hold run time configuration Sami Kerola
2014-05-04 15:49 ` [PATCH 09/15] cytune: pull signal handling and statistic priting apart Sami Kerola
2014-05-04 15:49 ` [PATCH 10/15] cytune: remove unnecessary type casts Sami Kerola
2014-05-04 15:49 ` [PATCH 11/15] cytune: deprecate undescriptive options Sami Kerola
2014-05-04 15:49 ` [PATCH 12/15] cytune: add filename to struct cyclades_control Sami Kerola
2014-05-04 15:49 ` [PATCH 13/15] cytune: add noreturn function attributes Sami Kerola
2014-05-04 15:49 ` [PATCH 14/15] cytune: use matching type in struct cyclades_control with kernel Sami Kerola
2014-05-04 15:49 ` [PATCH 15/15] cytune: update copyright Sami Kerola
2014-05-07 7:10 ` [PATCH 00/15] cytune modernization Karel Zak
2014-05-07 8:12 ` Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399278878.12657.113701373.0499DDA9@webmail.messagingengine.com \
--to=bensberg@justemail.net \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox