Util-Linux package development
 help / color / mirror / Atom feed
From: Stanislav Brabec <sbrabec@suse.cz>
To: Dave Reisner <d@falconindy.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Fix fsck -C {fd} parsing
Date: Wed, 25 Mar 2015 02:10:07 +0100	[thread overview]
Message-ID: <1427245807.4476.0@utx> (raw)
In-Reply-To: <20150324221615.GB513@rampage>

Dne 24.3.2015 23:16:15 napsal Dave Reisner:
> On Tue, Mar 24, 2015 at 09:01:10PM +0100, Stanislav Brabec wrote:
> > Both fsck(8) and fsck --help documents progress bar redirection as
> > -C {fd}
> >
> > This did not work, and only -C{fd} and "-C {fd}" worked.
> 
> Perhaps rather than break the existing behavior it might be better to
> make the documentation match reality.

It does not break the existing behavior. It just fixes the documented
behavior.

The existing parser was apparently broken: When parsing e. g. -C 3, it
detected the -C standing alone, and then attempts to interpret "-C" as
number instead of parsing of next argument. It fails, so the next
argument is interpreted as stand-alone argument.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec@suse.cz
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                  fax: +420 284 084 001
Czech Republic                                    http://www.suse.cz/

  reply	other threads:[~2015-03-25  1:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 20:01 [PATCH] Fix fsck -C {fd} parsing Stanislav Brabec
2015-03-24 22:16 ` Dave Reisner
2015-03-25  1:10   ` Stanislav Brabec [this message]
2015-03-25  8:30   ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427245807.4476.0@utx \
    --to=sbrabec@suse.cz \
    --cc=d@falconindy.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox