From: Karel Zak <kzak@redhat.com>
To: Stanislav Brabec <sbrabec@suse.cz>, util-linux@vger.kernel.org
Subject: Re: [PATCH] Fix fsck -C {fd} parsing
Date: Wed, 25 Mar 2015 09:30:36 +0100 [thread overview]
Message-ID: <20150325083036.GF1749@ws.net.home> (raw)
In-Reply-To: <20150324221615.GB513@rampage>
On Tue, Mar 24, 2015 at 06:16:15PM -0400, Dave Reisner wrote:
> On Tue, Mar 24, 2015 at 09:01:10PM +0100, Stanislav Brabec wrote:
> > Both fsck(8) and fsck --help documents progress bar redirection as
> > -C {fd}
> >
> > This did not work, and only -C{fd} and "-C {fd}" worked.
Applied, thanks (please, Signed-off-by: next time).
> Perhaps rather than break the existing behavior it might be better to
> make the documentation match reality.
Stanislav is right, it's pretty obvious from code:
> > } else if (i+1 < argc && *argv[i+1] != '-') { /* -C <fd> */
> > - progress_fd = string_to_int(argv[i]);
> > + progress_fd = string_to_int(argv[i+1]);
the "if()" checks for the next item in argv[], but string_to_int()
has been used with argv[i].
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-03-25 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 20:01 [PATCH] Fix fsck -C {fd} parsing Stanislav Brabec
2015-03-24 22:16 ` Dave Reisner
2015-03-25 1:10 ` Stanislav Brabec
2015-03-25 8:30 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325083036.GF1749@ws.net.home \
--to=kzak@redhat.com \
--cc=sbrabec@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox