Util-Linux package development
 help / color / mirror / Atom feed
From: Chen Qi <Qi.Chen@windriver.com>
To: <util-linux@vger.kernel.org>
Subject: include errno.h instead of argp.h
Date: Mon, 31 Aug 2015 16:23:45 +0800	[thread overview]
Message-ID: <1441009426-13799-2-git-send-email-Qi.Chen@windriver.com> (raw)
In-Reply-To: <1441009426-13799-1-git-send-email-Qi.Chen@windriver.com>

configure should include errno.h instead of argp.h when
checking for presence of program_invocation_short_name
uclibc defines this to be const char* unlike util-linux-ng
which defines this to be char* so this error goes unnoticed
on glibc/eglibc systems.

here is the error it fixes

in file included from mountP.h:14:0,                                                                               
                 from cache.c:29:                                                                                  
/home/kraj/work/slugos/build/tmp-slugos-uclibc/sysroots/nslu2le/usr/include/errno.h:55:46: error: conflicting types for '__progname'                                                                                                  
../../../include/c.h:118:14: note: previous declaration of '__progname' was here                                   
make[3]: *** [cache.lo] Error 1          


Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Jonathan Liu <net147@gmail.com>

Index: util-linux-2.22.1/configure.ac
===================================================================
--- util-linux-2.22.1.orig/configure.ac
+++ util-linux-2.22.1/configure.ac
@@ -372,7 +372,7 @@ esac
 
 AC_MSG_CHECKING([whether program_invocation_short_name is defined])
 AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
-	#include <argp.h>
+	#include <errno.h>
 ]], [[
 	program_invocation_short_name = "test";
 ]])], [

  reply	other threads:[~2015-08-31  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31  8:23 [PATCH] sys-utils/Makemodule.am: fix parallel build issue Chen Qi
2015-08-31  8:23 ` Chen Qi [this message]
2015-08-31  9:33   ` include errno.h instead of argp.h Karel Zak
2015-08-31  8:23 ` replace siginterrupt with sigaction Chen Qi
2015-08-31  9:37   ` Karel Zak
2015-08-31  9:27 ` [PATCH] sys-utils/Makemodule.am: fix parallel build issue Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441009426-13799-2-git-send-email-Qi.Chen@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox