From: Karel Zak <kzak@redhat.com>
To: Chen Qi <Qi.Chen@windriver.com>
Cc: util-linux@vger.kernel.org
Subject: Re: include errno.h instead of argp.h
Date: Mon, 31 Aug 2015 11:33:06 +0200 [thread overview]
Message-ID: <20150831093306.GD2726@ws.net.home> (raw)
In-Reply-To: <1441009426-13799-2-git-send-email-Qi.Chen@windriver.com>
On Mon, Aug 31, 2015 at 04:23:45PM +0800, Chen Qi wrote:
> Index: util-linux-2.22.1/configure.ac
We're just working on v2.27 :-)
> ===================================================================
> --- util-linux-2.22.1.orig/configure.ac
> +++ util-linux-2.22.1/configure.ac
> @@ -372,7 +372,7 @@ esac
>
> AC_MSG_CHECKING([whether program_invocation_short_name is defined])
> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
> - #include <argp.h>
> + #include <errno.h>
anyway, you're probably right.
It seems that our original AC_COMPILE_IFELSE() is copy & past from gnulib, but
gnulib checks for errno.h and then it uses the result by #ifdefs in the private
copy of the argp.h. The original author probably miss this detail.
Applied, thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-08-31 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 8:23 [PATCH] sys-utils/Makemodule.am: fix parallel build issue Chen Qi
2015-08-31 8:23 ` include errno.h instead of argp.h Chen Qi
2015-08-31 9:33 ` Karel Zak [this message]
2015-08-31 8:23 ` replace siginterrupt with sigaction Chen Qi
2015-08-31 9:37 ` Karel Zak
2015-08-31 9:27 ` [PATCH] sys-utils/Makemodule.am: fix parallel build issue Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831093306.GD2726@ws.net.home \
--to=kzak@redhat.com \
--cc=Qi.Chen@windriver.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox