last/last test fails

public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed

* last/last test fails
@ 2014-02-17  8:39 Mike Frysinger
  2014-02-17  9:05 ` Sami Kerola
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2014-02-17  8:39 UTC (permalink / raw)
  To: util-linux

[-- Attachment #1: Type: text/plain, Size: 4942 bytes --]

current git (24b2a479fd5ba138e9b836fa2115939eb3b59dfe) fails this test for me.
see recent blkid test post for config.log.
$ ./configure
$ make
$ ./tests/run.sh --nonroot --verbose last
...

     script: /usr/local/src/util-linux/tests/ts/last/last
    sub dir: /usr/local/src/util-linux/tests/ts/last
    top dir: /usr/local/src/util-linux/tests
       self: /usr/local/src/util-linux/tests/ts/last
  test name: last
  test desc: last
  component: last
  namespace: last/last
    verbose: yes
     output: /usr/local/src/util-linux/tests/output/last/last
   valgrind: /usr/local/src/util-linux/tests/output/last/last.vgdump
   expected: /usr/local/src/util-linux/tests/expected/last/last
 mountpoint: /usr/local/src/util-linux/tests/output/last/last-mnt

         last: last                           ...~~~ basic output ~~~
~~~ include system ~~~
~~~ dns short ~~~
~~~ dns long ~~~
~~~ dns host last ~~~
~~~ show ip ~~~
~~~ no host ~~~
~~~ full times ~~~
~~~ no time ~~~
~~~ iso-8601 time ~~~
~~~ since and until ~~~
~~~ present ~~~
 FAILED (last/last)

---------------------------------------------------------------------
  1 tests of 2 FAILED
---------------------------------------------------------------------

--- tests/expected/last/last	2014-01-17 20:16:42.575779735 +0000
+++ tests/output/last/last	2014-02-17 08:38:08.610056705 +0000
@@ -1,6 +1,6 @@
 ~~~ basic output ~~~
 rick     long         never-gonna-logo Thu Jan  1 00:00 - 03:14 (24855+03:14)
-torvalds linux        hobby            Mon Aug 26 00:57   still logged in
+torvalds linux        hobby            Mon Aug 26 00:57    gone - no logout
 reboot   system boot  system-name      Wed Aug 28 18:00   still running
 reboot   system boot  system-name      Wed Aug 28 16:00 - 17:00  (01:00)
 IPv4     root         dns-server       Wed Aug 28 13:00 - 14:00  (01:00)
@@ -17,7 +17,7 @@
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ include system ~~~
 rick     long         never-gonna-logo Thu Jan  1 00:00 - 03:14 (24855+03:14)
-torvalds linux        hobby            Mon Aug 26 00:57   still logged in
+torvalds linux        hobby            Mon Aug 26 00:57    gone - no logout
 reboot   system boot  system-name      Wed Aug 28 18:00   still running
 shutdown system down  system-name      Wed Aug 28 17:00 - 18:00  (01:00)
 reboot   system boot  system-name      Wed Aug 28 16:00 - 17:00  (01:00)
@@ -47,16 +47,16 @@
 
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ show ip ~~~
-torvalds linux        128.214.205.14   Mon Aug 26 00:57   still logged in
+torvalds linux        128.214.205.14   Mon Aug 26 00:57    gone - no logout
 
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ no host ~~~
-torvalds linux        Mon Aug 26 00:57   still logged in
+torvalds linux        Mon Aug 26 00:57    gone - no logout
 
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ full times ~~~
 rick     long         never-gonna-logo Thu Jan  1 00:00:00 1970 - Tue Jan 19 03:14:07 2038 (24855+03:14)
-torvalds linux        hobby            Mon Aug 26 00:57:08 1991   still logged in
+torvalds linux        hobby            Mon Aug 26 00:57:08 1991   gone - no logout
 reboot   system boot  system-name      Wed Aug 28 18:00:00 2013   still running
 reboot   system boot  system-name      Wed Aug 28 16:00:00 2013 - Wed Aug 28 17:00:00 2013  (01:00)
 IPv4     root         dns-server       Wed Aug 28 13:00:00 2013 - Wed Aug 28 14:00:00 2013  (01:00)
@@ -73,7 +73,7 @@
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ no time ~~~
 rick     long         never-gonna-logo   (24855+03:14)
-torvalds linux        hobby              logged in
+torvalds linux        hobby              - no logout
 reboot   system boot  system-name        running
 reboot   system boot  system-name         (01:00)
 IPv4     root         dns-server          (01:00)
@@ -90,7 +90,7 @@
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ iso-8601 time ~~~
 rick     long         never-gonna-logout 1970-01-01T00:00:00+0000 - 2038-01-19T03:14:07+0000 (24855+03:14)
-torvalds linux        hobby            1991-08-26T00:57:08+0000   still logged in
+torvalds linux        hobby            1991-08-26T00:57:08+0000   gone - no logout
 reboot   system boot  system-name      2013-08-28T18:00:00+0000   still running
 reboot   system boot  system-name      2013-08-28T16:00:00+0000 - 2013-08-28T17:00:00+0000  (01:00)
 IPv4     root         dns-server       2013-08-28T13:00:00+0000 - 2013-08-28T14:00:00+0000  (01:00)
@@ -115,7 +115,7 @@
 wtmp begins Wed Aug 28 03:00:00 2013
 ~~~ present ~~~
 rick     long         never-gonna-logo Thu Jan  1 00:00 - 03:14 (24855+03:14)
-torvalds linux        hobby            Mon Aug 26 00:57   still logged in
+torvalds linux        hobby            Mon Aug 26 00:57    gone - no logout
 runlevel foo          one              Wed Aug 28 11:00 - 12:00  (01:00)
 
 wtmp begins Wed Aug 28 03:00:00 2013
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: last/last test fails
  2014-02-17  8:39 last/last test fails Mike Frysinger
@ 2014-02-17  9:05 ` Sami Kerola
  2014-02-17  9:13   ` Mike Frysinger
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Kerola @ 2014-02-17  9:05 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: util-linux

On 17 February 2014 08:39, Mike Frysinger <vapier@gentoo.org> wrote:
> current git (24b2a479fd5ba138e9b836fa2115939eb3b59dfe) fails this test for me.
> see recent blkid test post for config.log.

Hi Mike,

My bad, when the earlier last(1) change was sent tests were not fixed
in same go, or by in another change immediately afterwards. See below
for late delivery of the test fix.

http://www.spinics.net/lists/util-linux-ng/msg08866.html

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: last/last test fails
  2014-02-17  9:05 ` Sami Kerola
@ 2014-02-17  9:13   ` Mike Frysinger
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2014-02-17  9:13 UTC (permalink / raw)
  To: kerolasa; +Cc: util-linux

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

On Monday, February 17, 2014 09:05:56 Sami Kerola wrote:
> On 17 February 2014 08:39, Mike Frysinger <vapier@gentoo.org> wrote:
> > current git (24b2a479fd5ba138e9b836fa2115939eb3b59dfe) fails this test for
> > me. see recent blkid test post for config.log.
> 
> My bad, when the earlier last(1) change was sent tests were not fixed
> in same go, or by in another change immediately afterwards. See below
> for late delivery of the test fix.
> 
> http://www.spinics.net/lists/util-linux-ng/msg08866.html

ah, figures i wait until just after a fix is posted to report ;).  it does fix 
the issue for me.  thanks !
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-17  9:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-17  8:39 last/last test fails Mike Frysinger
2014-02-17  9:05 ` Sami Kerola
2014-02-17  9:13   ` Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox