Re: what happend with hwclock patches?

Re: what happend with hwclock patches?

[Karel Zak]

On Tue, Mar 06, 2007 at 08:06:27PM -0800, David Brownell wrote:
> See
>   http://bugzilla.kernel.org/show_bug.cgi?id=8138

 Thanks for this link. The patch is not applied yet. Maybe I should
 release a snapshot (at least) with urgent things like hwclock or some
 mount patches.

 But I think you should ask downstream (your distribution) maitainer
 to apply these kind of patches. They have pretty stable util-linux
 packages now. I'll need few weeks to prepare useful util-linux-ng release.

 (I'm going to add the patch to Fedora tree.)

> I see there's a GIT archive but you don't seem to have merged the patch I sent
> you back in November ... and the GIT tree doesn't show any active development,
> no commits except syncing to old releases.

 Please, don't use broken gitweb at kernel.org or use it very carefully.

 There is active development, see "log" in the devel branch:

   http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=log;h=devel

 Number of applied patches:

    $ git rev-list --pretty=oneline  devel ^master | wc -l
    52

 Number of patches in queue:

    $ ls util-* | wc -l
    49

 The good news is that I have more time and I work on that full time
 now.

        Karel

-- 
 Karel Zak  <kzak@redhat.com>

Re: what happend with hwclock patches?

[David Brownell]

On Wednesday 07 March 2007 2:42 am, Karel Zak wrote:
>  Thanks for this link. The patch is not applied yet. Maybe I should
>  release a snapshot (at least) with urgent things like hwclock or some
>  mount patches.

Something like that would probably be a good thing.   The visibility that
patches are finally getting released will help restart machinery that's had
sand in its gears for way too long.


>  But I think you should ask downstream (your distribution) maitainer
>  to apply these kind of patches. They have pretty stable util-linux
>  packages now. I'll need few weeks to prepare useful util-linux-ng release.
>
> (I'm going to add the patch to Fedora tree.)

Thing is, distros are more likely to notice an updated util-linux package
than Yet Another Patch That Should Have Come From Upstream ... and the issue
is not _my_ distro (heck, I patched my systems directly) but every distro
that could potentially run a 2.6.21 kernel.  I am *NOT* in touch with many
such maintainers.  


> On Tue, Mar 06, 2007 at 08:06:27PM -0800, David Brownell wrote:
> 
> > I see there's a GIT archive but you don't seem to have merged the patch I sent
> > you back in November ... and the GIT tree doesn't show any active development,
> > no commits except syncing to old releases.
> 
>  Please, don't use broken gitweb at kernel.org or use it very carefully.
> 
>  There is active development, see "log" in the devel branch:
> 
>    http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=log;h=devel

Well, by active development I included "merging patches submitted" e.g. hwclock,
but it's also rather conventional to have patches show up on mainline instead of
only on branches.  See for example the kernel tree, or essentially any other tree...

It stiil doesn't *show* that development in the usual way.  Attributing the issue
to gitweb isn't relevant; lots of people don't know more than "git pull", and if
that doesn't give them updates, they effectively didn't happen.


>  The good news is that I have more time and I work on that full time
>  now.

That's good to know.  As you're well aware, the fact that this package
is an orphan has made trouble.  No real release since 2005, etc ...

- Dave

Re: what happend with hwclock patches?

[Karel Zak]

On Wed, Mar 07, 2007 at 09:42:49AM -0800, David Brownell wrote:
> >  There is active development, see "log" in the devel branch:
> > 
> >    http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=log;h=devel
> 
> Well, by active development I included "merging patches submitted" e.g. hwclock,

Sure, but the util-linux-ng is still not in the condition when I'll
merging patches ASAP. There are tons of others and more important
patches, there wasn't any tests, there was broken build system ...
Don't forget that the code has been unmaintained for almost 2 years.

Please, be patient at least for next 1-2 months.

BTW, "active" also means that someone answers your mails. I hope you
see the change :-)))

> but it's also rather conventional to have patches show up on mainline instead of
> only on branches.  See for example the kernel tree, or essentially any other tree...
> 
> It stiil doesn't *show* that development in the usual way.  Attributing the issue
> to gitweb isn't relevant; lots of people don't know more than "git pull", and if
> that doesn't give them updates, they effectively didn't happen.

$ git clone git://git.kernel.org/pub/scm/utils/util-linux-ng/util-linux-ng.git util-linux-ng
$ git checkout -f devel
$ git log

Well, we're very exotic. We use branches.

There is:

$ cat .git/remotes/origin
URL: git://git.kernel.org/pub/scm/utils/util-linux-ng/util-linux-ng.git
Pull: refs/heads/master:refs/heads/origin
Pull: refs/heads/devel:refs/heads/devel

after "git clone", so I don't see any problem with "git pull". You
should see updates in the 'devel' branch as well.

Also see:
    http://userweb.kernel.org/~kzak/util-linux-ng/


I believe there is more light now :-)

      Karel

-- 
 Karel Zak  <kzak@redhat.com>

Re: what happend with hwclock patches?

[David Brownell]

On Wednesday 07 March 2007 11:01 am, Karel Zak wrote:
> On Wed, Mar 07, 2007 at 09:42:49AM -0800, David Brownell wrote:
> > >  There is active development, see "log" in the devel branch:
> > > 
> > >    http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=log;h=devel
> > 
> > Well, by active development I included "merging patches submitted" e.g. hwclock,
> 
> Sure, but the util-linux-ng is still not in the condition when I'll
> merging patches ASAP. There are tons of others and more important
> patches, there wasn't any tests, there was broken build system ...
> Don't forget that the code has been unmaintained for almost 2 years.

I'd call some of that "catching up with the backlog", which is
of course one kind of development.  OK, so I'm picky; shoot me!

I was pleased to see tests getting added.  It's as if this were
becoming a real software project ... ;)


> Please, be patient at least for next 1-2 months.
> 
> BTW, "active" also means that someone answers your mails. I hope you
> see the change :-)))

Yes indeedy!!


> 
> Also see:
>     http://userweb.kernel.org/~kzak/util-linux-ng/
> 
> 
> I believe there is more light now :-)

Yes.  Worth posting a status update to LKML?

- Dave