Re: [PATCH] umount: allow non-root umount of FUSE even if not in fstab

[Petr Uzel <petr.uzel@suse.cz>]

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

On Tue, Mar 29, 2011 at 12:03:44AM +0200, Karel Zak wrote:
> On Mon, Mar 28, 2011 at 04:04:56PM +0200, Petr Uzel wrote:
> > I have to admit that I don't like it very much, because:
> 
> I don't like it too :-)

I'm not surprised :)

> 
> > - it complicates umount
> > - duplicates code from fusermount
> > - should (???) be implemented using umount helpers
> 
> [...]
> 
> > +		/* If this is fuse-based filesystem, allow user unmount even
> > +		 * if the FS is not in fstab.
> > +		 *
> > +		 * Based on fusermount code. */
> > +		if (strcmp(mc->m.mnt_type, "fuse") == 0 ||
> > +		    strcmp(mc->m.mnt_type, "fuseblk") == 0 ||
> > +		    strncmp(mc->m.mnt_type, "fuse.", 5) == 0 ||
> > +		    strncmp(mc->m.mnt_type, "fuseblk.", 8) == 0) {
> 
> Wouldn't be better to always call /sbin/umount.fuse for non-roots (except
> umount -i)? 

Yes, that's what I meant by umount helpers. The problem is that AFAICS
fuse does not provide this helper.

@Miklos: what do you think? Would it make sense to have umount.fuse
(most likely as symlink to /sbin/mount.fuse)? I could look into it.

> 
> I believe more and more that we need something like
> 
>     /etc/mount.d/{fuse,foo,...}.conf
> 
> where we can define such behavior for some filesystems.

Hm, I fail to understand what (regarding to this 'issue') would
you configure there. I can imagine e.g. per-fs-type default mount
options or enable/disable 'user mounts' (-i) per fs-type.

Is this what you think that should be configured via /etc/mount.d/*,
or something else?

Thanks,

Petr

--
Petr Uzel
IRC: ptr_uzl @ freenode

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]