Re: [PATCH] lscpu: add support for books

[Karel Zak <kzak@redhat.com>]

On Tue, Jul 05, 2011 at 01:29:10PM +0200, Heiko Carstens wrote:
> This patch adds support for books in cpu topology output. 

 Thanks!

> Please note that I assume that other programs that get fed by the
> output of lscpu actually parse the last comment line and react in a
> sane way if new entries appear in the cpu list.

 Never assume anything :-)

> Also the readable output is changed from
> "CPU socket(s):" to "Socket(s) per book:" or simply "Socket(s):" in the
> absence of books.

 You're right, the "Socket(s)" is probably better. Unfortunately it's
 not backwardly compatible (for people who use "lscpu | grep ..."), so
 I'll add a note to the ReleaseNotes...

> @@ -732,7 +750,7 @@ print_parsable(struct lscpu_desc *desc)
>  	"# The following is the parsable format, which can be fed to other\n"
>  	"# programs. Each different item in every column has an unique ID\n"
>  	"# starting from zero.\n"
> -	"# CPU,Core,Socket,Node"));
> +	"# CPU,Core,Socket,Book,Node"));

 It would be better to use

    # CPU,Core,Socket,Node,Book

 to keep it usable for stupid scripts where the header is not parsed.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com