Re: [PATCH] lscpu: add support for books

[Karel Zak <kzak@redhat.com>]

On Wed, Jul 13, 2011 at 09:16:18AM +0530, Heiko Carstens wrote:
> thanks. I updated the patch accordingly (see below).

 Applied, thanks.

> Just another thing: there are more per cpu informations that are present
> on s390 that I would also like to the parseable output. However, somehow
> it won't fit to the current approach that lscpu -p prints everything
> with a unique id starting from zero.
> For example the cpus on s390 can be in any of one of the states
> horizontal,vertical:low,vertical:medium or vertical:high (that's just
> an information of how the hypervisor schedules the cpus).
> How is that supposed to be mapped to current approach?
> Map these simply to numbers? E.g. horizontal would be mapped to 0,
> vertical:low would be mapped to 1 and so on?

 Probably, the most important is keep it backwardly compatible ;-)

> Also would I also need a new seperation character between caches and
> new information?

 I'm not sure if the currently used extra separators (,,) for the
 caches is a good idea. Maybe it would be better to force people to
 parse the last comment line where is the header for the columns.

> I'm asking because the output of caches is optional and if something
> new would be added, it seem to get messy in the long term because of
> all seperation characters that may or may not be there. No?

 I agree. Maybe you can add the new things before the caches (as you
 already added 'Book' column).

 The ideal solution is to extend the "-p" functionality and allow to 
 specify expected columns at command line, something like:

    lscpu -p -o cpu,core,book,socket

 We already use the same idea for findmnt and lscpu.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com