losetup --all --verbose results in usage

losetup --all --verbose results in usage

[Bernhard Voelker]

I was surprised that running
	mount/losetup --all --verbose
results in usage().

As -a is the option to list all used loop devices,
one might think that -v adds some more info to the output.

Neither --help nor the man pages nor the info page tells
that -a doesn't accept other options:

mount/lomount.c (line 1133):

         } else if (all) {
                 if (argc > 2)
                         usage(stderr);

Should we work on this?
If it's not possible to output more information with
-v, then it would maybe make sense to ignore it, right?

Have a nice day,
Berny

Re: losetup --all --verbose results in usage

[Davidlohr Bueso]

On Wed, 2011-08-17 at 16:12 +0200, Bernhard Voelker wrote:
> I was surprised that running
> 	mount/losetup --all --verbose
> results in usage().
> 
> As -a is the option to list all used loop devices,
> one might think that -v adds some more info to the output.
> 

The verbose option is quite broken, yes.

> Neither --help nor the man pages nor the info page tells
> that -a doesn't accept other options:
> 
> mount/lomount.c (line 1133):
> 
>          } else if (all) {
>                  if (argc > 2)
>                          usage(stderr);
> 
> Should we work on this?

I'm actually rewriting this tool to make use of our new loop library.
I'll address this issue here as well, thanks for the heads up.

- Davidlohr

Re: losetup --all --verbose results in usage

[Karel Zak]

On Wed, Aug 17, 2011 at 04:12:53PM +0200, Bernhard Voelker wrote:
> I was surprised that running
> 	mount/losetup --all --verbose
> results in usage().

 Fixed. losetup -a -v works now.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: losetup --all --verbose results in usage

[Bernhard Voelker]

On 08/17/2011 04:22 PM, Davidlohr Bueso wrote:
> On Wed, 2011-08-17 at 16:12 +0200, Bernhard Voelker wrote:
>> I was surprised that running
>> 	mount/losetup --all --verbose
>> results in usage().
...
> I'm actually rewriting this tool to make use of our new loop library.
> I'll address this issue here as well, thanks for the heads up.

great - I have to thank you!

Have a nice day,
Berny

Re: losetup --all --verbose results in usage

[Bernhard Voelker]

On 08/17/2011 04:44 PM, Karel Zak wrote:
> On Wed, Aug 17, 2011 at 04:12:53PM +0200, Bernhard Voelker wrote:
>> I was surprised that running
>> 	mount/losetup --all --verbose
>> results in usage().
>
>   Fixed. losetup -a -v works now.
>
>      Karel

uh, that was fast.
Thanks.

Berny