Re: [PATCH 0/4] Add functions to the fsck wrapper to improve standalone operation.

[Karel Zak <kzak@redhat.com>]

On Wed, Feb 15, 2012 at 04:06:35PM +0000, Pádraig Brady wrote:
> On 02/15/2012 03:09 PM, Frank Mayhar wrote:
> > 2012/2/15 Pádraig Brady <P@draigbrady.com>:
> >> On 02/07/2012 09:05 PM, Frank Mayhar wrote:
> >>> This set of patches adds functions that help improve fsck operation in
> >>> large installations and when running in unattended or headless mode.  It
> >>> adds support for reporting rusage statistics for the individual fsck
> >>> runs, for capturing fsck output, for killing fsck runs that take too
> >>> long and for running scripts when each fsck completes.
> >>>
> >>> We're currently using these functions to improve our fsck monitoring
> >>> capability and to replace some unwieldy and hard-to-maintain shell
> >>> scripts.
> >>
> >> Couldn't you do this with separate fsck command runs,
> >> and use standard system utils?
> > 
> > Yes, of course.  That's where the "unwieldy and hard-to-maintain shell
> > scripts" came in.  Putting the functions in the wrapper itself, on the
> > other hand, means the scripts don't have to reimplement functions that
> > already exist there (like parallelizing the fsck runs or tracking exit

 BTW, the latest fsck supports new -l option (lock disk) for parallel
 fsck processes. So you can start arbitrary number of

    fsck -l /dev/xxx

 without care about performance. We use it for systems with systemd
 where fsck is executed per device (fstab entry).

 If you want to use the same thing for the classic init scripts then 
 you can use something like

    for x in $(findmnt --fstab -n -o SOURCE); do
        fsck -l $x &< /var/log/fsck-$x &
    done

 rather tan fsck -A. Add some extra checks (completion scripts) to this
 for() should be pretty simple.

> > status), eliminates some external dependencies and makes the process
> > quite a bit less fragile.
> 
> OK, thanks for the clarification.
> 
> It seems to me that these functions are supported
> by quite simple shell scripting as I demonstrated.

 I have no problem with proposed -r option (to report memory and
 runtime statistics) and -O option to force-kill fscks that run too
 long.

 ... but I'm still not sure if we really need the completion script.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com