public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [PATCH] Add 'internal-only(i)' to non-root allowed option
@ 2012-02-26 11:06 raghu.prabhu13
  2012-02-28 14:40 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: raghu.prabhu13 @ 2012-02-26 11:06 UTC (permalink / raw)
  To: util-linux; +Cc: raghu.prabhu13, Raghavendra D Prabhu

From: Raghavendra D Prabhu <rprabhu@wnohang.net>

Commit ce433404 introduced the change, which causes something like mount -i
<user-mount-path> to break which worked well before util-linux-2.21, now it
gives message 'mount: only root can use "--internal-only" option' when that
shouldn't be the case when it is already in fstab.

Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
---
 sys-utils/mount.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys-utils/mount.c b/sys-utils/mount.c
index 3fbac04..d2ed296 100644
--- a/sys-utils/mount.c
+++ b/sys-utils/mount.c
@@ -708,7 +708,7 @@ int main(int argc, char **argv)
 					longopts, NULL)) != -1) {
 
 		/* only few options are allowed for non-root users */
-		if (mnt_context_is_restricted(cxt) && !strchr("hlLUVvpr", c))
+		if (mnt_context_is_restricted(cxt) && !strchr("hlLUVvpri", c))
 			exit_non_root(option_to_longopt(c, longopts));
 
 		switch(c) {
-- 
1.7.9.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [PATCH] Add 'internal-only(i)' to non-root allowed option
  2012-02-26 11:06 [PATCH] [PATCH] Add 'internal-only(i)' to non-root allowed option raghu.prabhu13
@ 2012-02-28 14:40 ` Karel Zak
  0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2012-02-28 14:40 UTC (permalink / raw)
  To: raghu.prabhu13; +Cc: util-linux, Raghavendra D Prabhu

On Sun, Feb 26, 2012 at 04:36:42PM +0530, raghu.prabhu13@gmail.com wrote:
>  sys-utils/mount.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

 Applied, thanks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-28 14:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-26 11:06 [PATCH] [PATCH] Add 'internal-only(i)' to non-root allowed option raghu.prabhu13
2012-02-28 14:40 ` Karel Zak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox