public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Matt Burgess <matthew@linuxfromscratch.org>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: mount -f regression in v2.21's new-mount
Date: Mon, 12 Mar 2012 15:32:59 +0100	[thread overview]
Message-ID: <20120312143259.GB27749@x2.net.home> (raw)
In-Reply-To: <1331492786.1816.2.camel@kyoto.localdomain>

On Sun, Mar 11, 2012 at 07:06:26PM +0000, Matt Burgess wrote:
> On Fri, 2012-03-09 at 13:29 +0100, Karel Zak wrote:
> > On Fri, Mar 09, 2012 at 04:30:02AM -0700, Matthew Burgess wrote:
> > > On Fri, 9 Mar 2012 11:53:04 +0100, Karel Zak <kzak@redhat.com> wrote:
> > > > On Thu, Mar 08, 2012 at 08:25:00PM +0000, Matt Burgess wrote:
> > > >> I've attached LIBMOUNT_DEBUG output from the 'mount -a' call that our
> > > >> bootscript does.  Note how mount correctly detects that /proc, /sys
> > > > 
> > > >  No, it calls mount(2) syscall for /proc. The problem is that the
> > > >  detection code expects /proc/self/mountinfo (used on systems with
> > > >  mtab -> /proc/mounts symlink), but your system uses regular mtab.
> > > > 
> > > >  I'll fix it. Thanks.
> > 
> >  Fixed, try git pull.
> 
> Thanks, that's sorted it!
> > 
> > > Thanks!  Is there a consensus opinion on whether users should be
> > > using a regular mtab or a symlink to /proc/self/mountinfo?
> > 
> >  - disadvantage is that some userspace utils (e.g. df(1) are not able
> >    to de-duplicate list of mounted filesystem (bind mounts))
> > 
> >  + advantage is that there is only one list of mounted filesystems
> >    with always valid mount options (on systems with mtab is not problem
> >    to have 'rw' in mtab for read-only NFS, etc.), no problems with
> >    namespaces, not writable files in /etc, no mtab lock, etc.
> > 
> >  The symlink is required for systemd.
> 
> Thanks for the info.  Looks like there are more advantages than
> disadvantages.  Without wishing to stray too far off-topic, do you know
> if the Coreutils folks are aware of/looking at the 'df' issue?

 My wish:

    - add FS de-duplicate function to libmount 
    - add SIZE, USE, AVAILABLE, USE% columns to findmnt
    - add --df to findmnt
    - try to implement df(1) compatible output if findmnt argv[0] is
      df ;-)))


 Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  parent reply	other threads:[~2012-03-12 15:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 22:43 mount -f regression in v2.21's new-mount Matt Burgess
2012-03-07  7:49 ` Karel Zak
2012-03-07 22:10   ` Matt Burgess
2012-03-08  9:23     ` Karel Zak
2012-03-08 20:25       ` Matt Burgess
2012-03-09 10:53         ` Karel Zak
2012-03-09 11:30           ` Matthew Burgess
2012-03-09 12:29             ` Karel Zak
2012-03-11 19:06               ` Matt Burgess
2012-03-12 14:09                 ` Voelker, Bernhard
2012-03-12 14:32                 ` Karel Zak [this message]
2012-03-12 17:17                   ` Pádraig Brady
2012-03-09 14:22             ` Petr Uzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312143259.GB27749@x2.net.home \
    --to=kzak@redhat.com \
    --cc=matthew@linuxfromscratch.org \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox