From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [pull] chkdupexe, a bug, version numbers and bashisms
Date: Fri, 30 Mar 2012 17:04:57 +0200 [thread overview]
Message-ID: <20120330150457.GE23437@x2.net.home> (raw)
In-Reply-To: <CAG27Bk3Jrh_22adczBYq77u4p7GqmtUw2ELbABU77j3_4SySvA@mail.gmail.com>
Merged, but
On Tue, Mar 20, 2012 at 08:27:01PM +0100, Sami Kerola wrote:
> Sami Kerola (31):
> chkdupexe: reimplement command in C
please, send the new chkdupexe to mailing list for review.
> addpart: align with util-linux coding standards
> delpart: align with util-linux coding standards
Fixed...
if ((fd = open(argv[1], O_RDONLY)) < 0)
err(EXIT_FAILURE, "%s", argv[1]);
...
err(EXIT_FAILURE, "BLKPG");
"%s", "BLKPG" are not usable error messages.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-03-30 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 19:27 [pull] chkdupexe, a bug, version numbers and bashisms Sami Kerola
2012-03-30 15:04 ` Karel Zak [this message]
2012-04-01 18:19 ` Sami Kerola
2012-04-01 18:19 ` [PATCH 1/3] tests: hwclock: locate ntpdate by using path Sami Kerola
2012-04-02 11:22 ` Karel Zak
2012-04-01 18:19 ` [PATCH 2/3] script: error in usage() output Sami Kerola
2012-04-02 11:27 ` Karel Zak
2012-04-01 18:19 ` [PATCH 3/3] chkdupexe: reimplement command in C Sami Kerola
2012-04-02 11:10 ` Karel Zak
2012-04-02 11:53 ` Sami Kerola
2012-04-02 12:12 ` Karel Zak
2012-04-04 10:24 ` Karel Zak
2012-04-02 12:22 ` Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330150457.GE23437@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox