public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: "Voelker, Bernhard" <bernhard.voelker@siemens-enterprise.com>
Cc: util-linux <util-linux@vger.kernel.org>, Sami Kerola <kerolasa@iki.fi>
Subject: Re: eject on Cygwin?
Date: Mon, 23 Apr 2012 12:25:16 +0200	[thread overview]
Message-ID: <20120423102516.GA11847@x2.net.home> (raw)
In-Reply-To: <7856072A9D04C24B82DFE2B1112FE38A0F0FD7A0B9@MCHP058A.global-ad.net>

On Mon, Apr 23, 2012 at 11:49:37AM +0200, Voelker, Bernhard wrote:
> Karel Zak wrote:
> 
> > On Mon, Apr 23, 2012 at 11:31:11AM +0200, Voelker, Bernhard wrote:
> > > Is there a specific reason for this line in configure.ac?
> > >   UL_REQUIRES_LINUX([eject])
> > > 
> > > Can't Cygwin handle /dev/scd0 correctly? 
> > 
> >  I don't know, the code also depends on /sys to detect if the device
> >  is removable, it calls umount(2) syscall, etc.
> 
> okay, thanks.
> Anyway, porting u-l to cygwin is not much fun anymore,
> e.g. due to new close_stdout() which needs __fpending, and
> lib/randutils.c needs sys/syscall.h to check if __NR_gettid
> is defined etc.

It should be so pretty simple to check for the unportable functions
in configure and add some #ifdef to include/closestream.h. It's no
problem if close_stdout() will do nothing on some platforms. Sami?

Anyway, we follow coreutils here, I guess coreutils already have some
fallbacks (they care about portability more that u-l :-).

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      parent reply	other threads:[~2012-04-23 10:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  9:31 eject on Cygwin? Voelker, Bernhard
2012-04-23  9:44 ` Karel Zak
2012-04-23  9:49   ` Voelker, Bernhard
2012-04-23 10:25     ` Davidlohr Bueso
2012-04-23 10:25     ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423102516.GA11847@x2.net.home \
    --to=kzak@redhat.com \
    --cc=bernhard.voelker@siemens-enterprise.com \
    --cc=kerolasa@iki.fi \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox