* RE: eject on Cygwin?
2012-04-23 9:49 ` Voelker, Bernhard
@ 2012-04-23 10:25 ` Davidlohr Bueso
2012-04-23 10:25 ` Karel Zak
1 sibling, 0 replies; 5+ messages in thread
From: Davidlohr Bueso @ 2012-04-23 10:25 UTC (permalink / raw)
To: Voelker, Bernhard; +Cc: Karel Zak, util-linux
On Mon, 2012-04-23 at 11:49 +0200, Voelker, Bernhard wrote:
> Karel Zak wrote:
>
> > On Mon, Apr 23, 2012 at 11:31:11AM +0200, Voelker, Bernhard wrote:
> > > Is there a specific reason for this line in configure.ac?
> > > UL_REQUIRES_LINUX([eject])
> > >
> > > Can't Cygwin handle /dev/scd0 correctly?
> >
> > I don't know, the code also depends on /sys to detect if the device
> > is removable, it calls umount(2) syscall, etc.
>
> okay, thanks.
> Anyway, porting u-l to cygwin is not much fun anymore,
> e.g. due to new close_stdout() which needs __fpending, and
> lib/randutils.c needs sys/syscall.h to check if __NR_gettid
> is defined etc.
Plus, like eject, most tools use a lot of sysfs and procfs files, which
are pretty Linux-specific.
>
> Have a nice day,
> Berny
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: eject on Cygwin?
2012-04-23 9:49 ` Voelker, Bernhard
2012-04-23 10:25 ` Davidlohr Bueso
@ 2012-04-23 10:25 ` Karel Zak
1 sibling, 0 replies; 5+ messages in thread
From: Karel Zak @ 2012-04-23 10:25 UTC (permalink / raw)
To: Voelker, Bernhard; +Cc: util-linux, Sami Kerola
On Mon, Apr 23, 2012 at 11:49:37AM +0200, Voelker, Bernhard wrote:
> Karel Zak wrote:
>
> > On Mon, Apr 23, 2012 at 11:31:11AM +0200, Voelker, Bernhard wrote:
> > > Is there a specific reason for this line in configure.ac?
> > > UL_REQUIRES_LINUX([eject])
> > >
> > > Can't Cygwin handle /dev/scd0 correctly?
> >
> > I don't know, the code also depends on /sys to detect if the device
> > is removable, it calls umount(2) syscall, etc.
>
> okay, thanks.
> Anyway, porting u-l to cygwin is not much fun anymore,
> e.g. due to new close_stdout() which needs __fpending, and
> lib/randutils.c needs sys/syscall.h to check if __NR_gettid
> is defined etc.
It should be so pretty simple to check for the unportable functions
in configure and add some #ifdef to include/closestream.h. It's no
problem if close_stdout() will do nothing on some platforms. Sami?
Anyway, we follow coreutils here, I guess coreutils already have some
fallbacks (they care about portability more that u-l :-).
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread