From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: "util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: [PATCH] tests: fix layout info in dos and non-dos mode fdisk test
Date: Wed, 1 Aug 2012 11:17:36 +0200 [thread overview]
Message-ID: <20120801091736.GB1019@x2.net.home> (raw)
In-Reply-To: <5018DCC8.1050803@bernhard-voelker.de>
On Wed, Aug 01, 2012 at 09:37:44AM +0200, Bernhard Voelker wrote:
> since you added the layout info to ts/fdisk/mbr-dos-mode, that test fails.
> It seems you inserted too many blanks in the header line (... or that test
> behaves differently on my machine).
> Likewise with the new mbr-nondos-mode test.
Hmm.. good catch.
> Given the result is not hosed on my machine, I've attached a patch
> to adapt the expected output of both tests.
This is not proper fix.
The whitespace is dynamically generated by fdisk according to device
name size. It means that we have to standardize the blanks in the
header line for the test.
The problem should be fixed now.
It would be nice standardize the headers and devnames in all tests
where is fdisk output.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-08-01 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 7:37 [PATCH] tests: fix layout info in dos and non-dos mode fdisk test Bernhard Voelker
2012-08-01 9:17 ` Karel Zak [this message]
2012-08-01 10:15 ` Bernhard Voelker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801091736.GB1019@x2.net.home \
--to=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox