public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Reisner <d@falconindy.com>
To: util-linux@vger.kernel.org
Subject: loopdev regression with v2.23
Date: Sat, 11 May 2013 19:39:10 -0400	[thread overview]
Message-ID: <20130511233910.GO494@rampage> (raw)

Hi,

I have a bug report that points out that v2.23 has disallowed losetup of
a block device with an offset:

https://bugs.archlinux.org/task/35193

As I also note in the bug report, I've bisected this to commit 293714c0d15.

I'm not clear on what the proper fix is here -- "expected_size" is set
to 0 since the fstat call is performed on a special file which has a 0
size. Is the right thing to do simply return 0 if the size of the
"backing file" is 0?

There's also the problem of the error message -- the fabricated ERANGE
return fails to also set errno=ERANGE before returning.

Cheers,
Dave

             reply	other threads:[~2013-05-11 23:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 23:39 Dave Reisner [this message]
2013-05-13  9:07 ` loopdev regression with v2.23 Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130511233910.GO494@rampage \
    --to=d@falconindy.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox