From: Karel Zak <kzak@redhat.com>
To: util-linux@vger.kernel.org
Cc: Jeff Mahoney <jeffm@suse.com>
Subject: Re: loopdev regression with v2.23
Date: Mon, 13 May 2013 11:07:28 +0200 [thread overview]
Message-ID: <20130513090728.GB26163@x2.net.home> (raw)
In-Reply-To: <20130511233910.GO494@rampage>
On Sat, May 11, 2013 at 07:39:10PM -0400, Dave Reisner wrote:
> I have a bug report that points out that v2.23 has disallowed losetup of
> a block device with an offset:
>
> https://bugs.archlinux.org/task/35193
>
> As I also note in the bug report, I've bisected this to commit 293714c0d15.
>
> I'm not clear on what the proper fix is here -- "expected_size" is set
> to 0 since the fstat call is performed on a special file which has a 0
> size. Is the right thing to do simply return 0 if the size of the
> "backing file" is 0?
The right thing is to use size of the block device if the backing file
is a block device. Fixed. Git pull.
All this is workaround for kernel bug (already fixed in v3.9). I hope
that one day we will use KERNEL_VERSION macro to exclude all this
painful thing :-)
Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-05-13 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 23:39 loopdev regression with v2.23 Dave Reisner
2013-05-13 9:07 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513090728.GB26163@x2.net.home \
--to=kzak@redhat.com \
--cc=jeffm@suse.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox