* [PATCH] build-sys: simplify python detection
@ 2013-09-29 9:51 Sami Kerola
2013-09-30 12:05 ` Karel Zak
0 siblings, 1 reply; 2+ messages in thread
From: Sami Kerola @ 2013-09-29 9:51 UTC (permalink / raw)
To: util-linux; +Cc: kerolasa
This allows './configure --enable-most-builds' and 'make distcheck' to
work when both python2 and python3 are installed, and user has set python
version preference using symlink and PATH order.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
configure.ac | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 553228a..1f02bd8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1386,20 +1386,14 @@ AS_IF([test "x$with_python" != xno], [
# (minimal version is 2) but if major version is explicitly specified by
# --with-python=2 or --with-python=3 then we look for PKG module "python2" or
# "python3".
- pymajor="2"
- modname="python"
- AS_IF([test "x$withval" != xno -a "x$withval" != xyes], [
- pymajor="$withval"
- modname="python${pymajor}"
- ])
- PKG_CHECK_MODULES(PYTHON,[${modname} >= $pymajor],
- [have_python=yes
- AM_PATH_PYTHON([$pymajor])],
- [have_python=no])
+ AS_IF([test "x$withval" != xno -a "x$withval" != xyes],
+ [pymajor="$withval"; PYTHON=python${pymajor}], [pymajor="2"])
+ AM_PATH_PYTHON([$pymajor], [have_python=yes], [have_python=no])
AS_CASE([$with_python:$have_python],
[yes:no],
- [AC_MSG_ERROR([python selected but libpython not found])],
+ [AC_MSG_ERROR([python selected but libpython not found])]
)
+ PKG_CHECK_MODULES([PYTHON], [python-$PYTHON_VERSION])
UL_BUILD_INIT([pylibmount], [check])
UL_REQUIRES_HAVE([pylibmount], [python], [libpython])
@@ -1541,7 +1535,8 @@ AC_MSG_RESULT([
ldflags: ${LDFLAGS}
suid ldflags: ${SUID_LDFLAGS}
- Python: ${PYTHON_VERSION}
+ Python: ${PYTHON}
+ Python version: ${PYTHON_VERSION}
Python libs: ${pyexecdir}
Bash completions: ${with_bashcompletiondir}
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] build-sys: simplify python detection
2013-09-29 9:51 [PATCH] build-sys: simplify python detection Sami Kerola
@ 2013-09-30 12:05 ` Karel Zak
0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2013-09-30 12:05 UTC (permalink / raw)
To: Sami Kerola; +Cc: util-linux
On Sun, Sep 29, 2013 at 10:51:13AM +0100, Sami Kerola wrote:
> configure.ac | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-30 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-29 9:51 [PATCH] build-sys: simplify python detection Sami Kerola
2013-09-30 12:05 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox