[PATCH] su: Remove the impossible -C option to request the same session.

[PATCH] su: Remove the impossible -C option to request the same session.

[Colin Guthrie]

It's impossible to pass this argument so it is pointless to keep the
code to support it.
---
 login-utils/su-common.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index 7fd2792..ca9f24b 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -744,7 +744,6 @@ su_main (int argc, char **argv, int mode)
   int optc;
   const char *new_user = DEFAULT_USER, *runuser_user = NULL;
   char *command = NULL;
-  int request_same_session = 0;
   char *shell = NULL;
   struct passwd *pw;
   struct passwd pw_copy;
@@ -786,11 +785,6 @@ su_main (int argc, char **argv, int mode)
 	  command = optarg;
 	  break;
 
-        case 'C':
-          command = optarg;
-          request_same_session = 1;
-          break;
-
 	case 'f':
 	  fast_startup = true;
 	  break;
@@ -924,7 +918,7 @@ su_main (int argc, char **argv, int mode)
 
   authenticate (pw);
 
-  if (request_same_session || !command || !pw->pw_uid)
+  if (!command || !pw->pw_uid)
     same_session = 1;
 
   /* initialize shell variable only if "-u <user>" not specified */
-- 
1.8.4.3

Re: [PATCH] su: Remove the impossible -C option to request the same session.

[Karel Zak]

On Mon, Nov 18, 2013 at 02:44:00PM +0000, Colin Guthrie wrote:
> It's impossible to pass this argument so it is pointless to keep the
> code to support it.

 Really? See struct option longopts[] and --session-command.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH] su: Remove the impossible -C option to request the same session.

[Colin Guthrie]

'Twas brillig, and Karel Zak at 18/11/13 16:42 did gyre and gimble:
> On Mon, Nov 18, 2013 at 02:44:00PM +0000, Colin Guthrie wrote:
>> It's impossible to pass this argument so it is pointless to keep the
>> code to support it.
> 
>  Really? See struct option longopts[] and --session-command.

Gah, sorry! Could have sworn I'd searched for the 'C' but must have been
fat fingers while on a bumpy train.

Sorry 'bout that.

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/