[PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

[PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

[Sami Kerola]

In September 1752 the Gregorian reformation happen in Great Britain and
Dominions (including what is now the USA).  One could argue the cal(1)
should consider locale when determining the reformation, but such is
nearly impossible implement correctly.

The dates when reformation happen are split by areas that cannot be
expressed with current locales, for example the Netherlands is split to
two and Germany three categories depending on where in the modern country
one is.  Secondly the track when reformation happen is lost for some
countries, Lithuania or Japan are good examples of such.

One of the worst for a programmer is Sweden.  They got gradual calendar
change which made Swedish calendar to be completely out of sync.  Later
the Swedish calendar jumped in 1753 to be in sync with everyone else.

Notice that some countries, including Saudi Arabia, Ethiopia, Nepal, Iran
and Afghanistan, still have not adopted the Gregorian calendar.  Hence
the output of the cal(1) can be considered correct for most but not for
each individual separately.

References: http://calendopedia.com/gregory.htm
References: http://en.wikipedia.org/wiki/Gregorian_calendar#Gregorian_reform
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 misc-utils/cal.1 | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/misc-utils/cal.1 b/misc-utils/cal.1
index fa79f91..1ce0e26 100644
--- a/misc-utils/cal.1
+++ b/misc-utils/cal.1
@@ -102,17 +102,23 @@ specified, the current month's calendar is displayed.
 A year starts on Jan 1. The first day of the week is determined by the
 locale.
 .PP
-The Gregorian Reformation is assumed to have occurred in 1752 on the 3rd of
-September. By this time, most countries had recognized the reformation
-(although a few did not recognize it until the early 1900's). Ten days
-following that date were eliminated by the reformation, so the calendar for
-that month is a bit unusual.
-.PP
 The week numbering depends on the first day of the week. If Sunday (the
 default) is used for the first day of the week, then the customary North
 American numbering will be used, i.e. first Sunday of the week starts the
 first week. If Monday is selected, then the ISO-8601 standard week numbering
 is used, where the first Thursday is in week number 1.
+.SH BUGS
+.PP
+The
+.B cal
+is using for Gregorian reformation the date of 1752 on the 3rd of
+September when it happen in Great Britain and it's colonies (including
+what is now the USA).  Ten days following that date were eliminated by
+the reformation, so the calendar for that month is a bit unusual.  The
+history when calendar reformation happen in different locales is ignored.
+.PP
+Alternative calendars, such as the Umm al-Qura, the Solar Hijri, the Ge'ez,
+or the lunisolar Hindu, are not supported.
 .SH HISTORY
 A cal command appeared in Version 6 AT&T UNIX.
 .SH AVAILABILITY
-- 
1.8.5.2

Re: [PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

[Benno Schulenberg]

Hi Sami,

The change looks okay, but the wording needs some improvement.

On Sat, Dec 21, 2013, at 12:57, Sami Kerola wrote:
> +The
> +.B cal
> +is using for Gregorian reformation the date of 1752 on the 3rd of
> +September when it happen in Great Britain and it's colonies

s/is using for/program uses for the/
s/happen/happened/
s/it's/its/

Or better, written out in full:

  The cal program uses the 3rd of September 1752 as the date of
  the Gregorian calendar reformation -- that is when it happened
  in Great Britain and its colonies...

> +The
> +history when calendar reformation happen in different locales is ignored.

  The historical dates on which the calendar reform actually happened
  in the different countries (locales) are ignored.

Regards,

Benno

-- 
http://www.fastmail.fm - The way an email service should be

Re: [PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

[Sami Kerola]

On Sat, Dec 21, 2013 at 06:03:35PM +0100, Benno Schulenberg wrote:
> The change looks okay, but the wording needs some improvement.

Thank you for review Benno, the below resubmission uses your wording.

BTW after reading a bit about historic calendars I have lost hope
historically correct calendar would be doable.  If BC calendar is ever
made to work is should probably implement what modern day western people
can agree was correct, even if the people who lived at the time would
disagree.

--->8----
From: Sami Kerola <kerolasa@iki.fi>
Date: Sun, 22 Dec 2013 18:06:04 +0000
Subject: [PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

In September 1752 the Gregorian reformation happen in Great Britain and
Dominions (including what is now the USA).  One could argue the cal(1)
should consider locale when determining the reformation, but such is
nearly impossible implement correctly.

The dates when reformation happen are split by areas that cannot be
expressed with current locales, for example the Netherlands is split to
two and Germany three categories depending on where in the modern country
one is.  Secondly the track when reformation happen is lost for some
countries, Lithuania or Japan are good examples of such.

One of the worst for a programmer is Sweden.  They got gradual calendar
change which made Swedish calendar to be completely out of sync.  Later
the Swedish calendar jumped in 1753 to be in sync with everyone else.

Notice that some countries, including Saudi Arabia, Ethiopia, Nepal, Iran
and Afghanistan, still have not adopted the Gregorian calendar.  Hence
the output of the cal(1) cannot be considered to be correct for everyone.

References: http://calendopedia.com/gregory.htm
References: http://en.wikipedia.org/wiki/Gregorian_calendar#Gregorian_reform
Reviewed-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 misc-utils/cal.1 | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/misc-utils/cal.1 b/misc-utils/cal.1
index fa79f91..1ce0e26 100644
--- a/misc-utils/cal.1
+++ b/misc-utils/cal.1
@@ -102,17 +102,23 @@ specified, the current month's calendar is displayed.
 A year starts on Jan 1. The first day of the week is determined by the
 locale.
 .PP
-The Gregorian Reformation is assumed to have occurred in 1752 on the 3rd of
-September. By this time, most countries had recognized the reformation
-(although a few did not recognize it until the early 1900's). Ten days
-following that date were eliminated by the reformation, so the calendar for
-that month is a bit unusual.
-.PP
 The week numbering depends on the first day of the week. If Sunday (the
 default) is used for the first day of the week, then the customary North
 American numbering will be used, i.e. first Sunday of the week starts the
 first week. If Monday is selected, then the ISO-8601 standard week numbering
 is used, where the first Thursday is in week number 1.
+.SH BUGS
+.PP
+The
+.B cal
+is using for Gregorian reformation the date of 1752 on the 3rd of
+September when it happen in Great Britain and it's colonies (including
+what is now the USA).  Ten days following that date were eliminated by
+the reformation, so the calendar for that month is a bit unusual.  The
+history when calendar reformation happen in different locales is ignored.
+.PP
+Alternative calendars, such as the Umm al-Qura, the Solar Hijri, the Ge'ez,
+or the lunisolar Hindu, are not supported.
 .SH HISTORY
 A cal command appeared in Version 6 AT&T UNIX.
 .SH AVAILABILITY
-- 
1.8.5.2

Re: [PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

[Karel Zak]

On Sun, Dec 22, 2013 at 06:31:42PM +0000, Sami Kerola wrote:
>  misc-utils/cal.1 | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)

 Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH] docs: cal: mention where Gregorian reformation happen in September 1752

[Karel Zak]

On Sun, Dec 22, 2013 at 06:31:42PM +0000, Sami Kerola wrote:
>  misc-utils/cal.1 | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)

 Applied, thanks.
-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

[patch] cal: improve wording about when Gregorian reformation happened

[Benno Schulenberg]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]


On Mon, Jan 6, 2014, at 12:26, Karel Zak wrote:
> On Sun, Dec 22, 2013 at 06:31:42PM +0000, Sami Kerola wrote:
> >  misc-utils/cal.1 | 18 ++++++++++++------
> >  1 file changed, 12 insertions(+), 6 deletions(-)
> 
>  Applied, thanks.

Hmm...  I reviewed that change, but it appears Sami did not actually
process any of my comments into the second version of the patch --
or probably forgot to regenerate it?

Attached patch now makes the proposed changes to the current state.

Regards,

Benno

-- 
http://www.fastmail.fm - Accessible with your email software
                          or over the web


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-cal-in-man-page-improve-grammar-and-wording-of-the-r.patch --]
[-- Type: text/x-patch; name="0001-cal-in-man-page-improve-grammar-and-wording-of-the-r.patch", Size: 1556 bytes --]

From 26dd7a90cf5b0a6af373c44ec32c5c92562613c6 Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg@justemail.net>
Date: Mon, 6 Jan 2014 21:43:44 +0100
Subject: [PATCH] cal: in man page improve grammar and wording of the reformation limitation

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
---
 misc-utils/cal.1 |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/misc-utils/cal.1 b/misc-utils/cal.1
index c305eee..470d231 100644
--- a/misc-utils/cal.1
+++ b/misc-utils/cal.1
@@ -111,11 +111,12 @@ is used, where the first Thursday of the year is in week number 1.
 .PP
 The
 .B cal
-is using for Gregorian reformation the date of 1752 on the 3rd of
-September when it happen in Great Britain and it's colonies (including
-what is now the USA).  Ten days following that date were eliminated by
-the reformation, so the calendar for that month is a bit unusual.  The
-history when calendar reformation happen in different locales is ignored.
+program uses the 3rd of September 1752 as the date of the Gregorian calendar
+reformation -- that is when it happened in Great Britain and its colonies
+(including what is now the USA).  Ten days following that date were eliminated
+by this reformation, so the calendar for that month is rather unusual.
+The actual historical dates at which the calendar reform happened in all the
+different countries (locales) are ignored.
 .PP
 Alternative calendars, such as the Umm al-Qura, the Solar Hijri, the Ge'ez,
 or the lunisolar Hindu, are not supported.
-- 
1.7.0.4

Re: [patch] cal: improve wording about when Gregorian reformation happened

[Sami Kerola]

On 6 January 2014 20:55, Benno Schulenberg <bensberg@justemail.net> wrote:
> On Mon, Jan 6, 2014, at 12:26, Karel Zak wrote:
>> On Sun, Dec 22, 2013 at 06:31:42PM +0000, Sami Kerola wrote:
>> >  misc-utils/cal.1 | 18 ++++++++++++------
>> >  1 file changed, 12 insertions(+), 6 deletions(-)
>>
>>  Applied, thanks.
>
> Hmm...  I reviewed that change, but it appears Sami did not actually
> process any of my comments into the second version of the patch --
> or probably forgot to regenerate it?
>
> Attached patch now makes the proposed changes to the current state.

Sorry Benno, it seems I made mess when handling patch files.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: [patch] cal: improve wording about when Gregorian reformation happened

[Karel Zak]

On Mon, Jan 06, 2014 at 09:55:54PM +0100, Benno Schulenberg wrote:
> Attached patch now makes the proposed changes to the current state.

 Cool, thanks. Applied.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com