Re: [PATCH] uuidd: use pkg-config to find systemd-deamon support

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1605 bytes --]

On Wednesday 08 January 2014 17:28:06 Sami Kerola wrote:
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -79,6 +79,7 @@ include libblkid/Makemodule.am
>  include libmount/Makemodule.am
>  include libfdisk/Makemodule.am
> 
> +if HAVE_COMMANDS
>  include schedutils/Makemodule.am
>  include text-utils/Makemodule.am
>  include term-utils/Makemodule.am
> @@ -92,6 +93,7 @@ include fdisks/Makemodule.am
>  include bash-completion/Makemodule.am
> 
>  include tests/Makemodule.am
> +endif	# HAVE_COMMANDS

aren't there some tests for the libs ?

> --- a/configure.ac
> +++ b/configure.ac
> @@ -704,6 +704,11 @@ AS_IF([test "x$with_utempter" = xyes], [
>    AM_CONDITIONAL([HAVE_UTEMPTER], [false])
>  ])
> 
> +AC_ARG_ENABLE([binaries],
> +  AS_HELP_STRING([--disable-binaries], [build only libraries]),
> +  [], [enable_libraries_only=yes]
> +)
> +AM_CONDITIONAL(HAVE_COMMANDS, test "x$enable_libraries_only" = xyes)

i'm not sure about this inversion of naming.  why can't it just use 
enable_binaries everywhere ?

> --- a/login-utils/Makemodule.am
> +++ b/login-utils/Makemodule.am
> @@ -196,14 +196,3 @@ test_logindefs_SOURCES = \
>  	login-utils/logindefs.c \
>  	login-utils/logindefs.h
>  test_logindefs_CPPFLAGS = -DTEST_PROGRAM $(AM_CPPFLAGS)
> -
> -
> -install-exec-hook:
> -if BUILD_SU
> -if MAKEINSTALL_DO_SETUID
> -	chmod 4755 $(DESTDIR)$(bindir)/su
> -endif
> -endif
> -if BUILD_VIPW
> -	cd $(DESTDIR)$(usrsbin_execdir) && ln -sf vipw vigr
> -endif

why does this need to move ?  this module isn't included when commands are 
disabled ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]