From: Karel Zak <kzak@redhat.com>
To: Scott Moser <smoser@ubuntu.com>
Cc: util-linux@vger.kernel.org, Philip Susi <psusi@ubuntu.com>
Subject: Re: [PATCH] fix partx --update ranges and out of order tables
Date: Tue, 14 Jan 2014 09:54:39 +0100 [thread overview]
Message-ID: <20140114085439.GF12700@x2.net.home> (raw)
In-Reply-To: <alpine.DEB.2.02.1401131526340.5329@brickies>
On Mon, Jan 13, 2014 at 03:32:49PM -0500, Scott Moser wrote:
> partx --update DEVICE NUMBER
> was broken in 2 cases:
> * if NUMBER != 1
> * if the partition table was "out of order".
> Ie, where sda2 came after sda3.
>
> fixes http://pad.lv/1244662.
> See bug for example recreates.
Good catch.
> - for (i = 0, n = lower; n <= upper; n++) {
> - par = blkid_partlist_get_partition(ls, i);
> - an = blkid_partition_get_partno(par);
> -
> - if (lower && n < lower)
> - continue;
> - if (upper && n > upper)
It was really stupid code :-(
Applied, thanks!
You forgot "Signed-off-by: ", I have fixed this mistake before commit
as I guess you agree with this change. OK?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-01-14 8:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 20:32 [PATCH] fix partx --update ranges and out of order tables Scott Moser
2014-01-14 8:54 ` Karel Zak [this message]
2014-01-14 14:41 ` Scott Moser
2014-01-14 14:43 ` Phillip Susi
2014-01-14 14:53 ` Scott Moser
2014-01-14 15:21 ` Phillip Susi
2014-01-15 9:55 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114085439.GF12700@x2.net.home \
--to=kzak@redhat.com \
--cc=psusi@ubuntu.com \
--cc=smoser@ubuntu.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox