From: Karel Zak <kzak@redhat.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: Scott Moser <smoser@ubuntu.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH] fix partx --update ranges and out of order tables
Date: Wed, 15 Jan 2014 10:55:28 +0100 [thread overview]
Message-ID: <20140115095528.GJ12700@x2.net.home> (raw)
In-Reply-To: <52D54D09.10506@ubuntu.com>
On Tue, Jan 14, 2014 at 09:43:21AM -0500, Phillip Susi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > +blkid_partition get_partition_by_partno(blkid_partlist ls, int n)
>
> I was wondering why libblkid didn't already have a function like this,
> should this be moved there instead of just being in partx.c?
Yes, good point.
I have moved the function to libblkid in the master branch (in the
stable/v2.24 is the original Scott's version -- I don't want to
change the API in x.y.1 releases). Thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2014-01-15 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 20:32 [PATCH] fix partx --update ranges and out of order tables Scott Moser
2014-01-14 8:54 ` Karel Zak
2014-01-14 14:41 ` Scott Moser
2014-01-14 14:43 ` Phillip Susi
2014-01-14 14:53 ` Scott Moser
2014-01-14 15:21 ` Phillip Susi
2014-01-15 9:55 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115095528.GJ12700@x2.net.home \
--to=kzak@redhat.com \
--cc=psusi@ubuntu.com \
--cc=smoser@ubuntu.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox