public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] hwclock: gettextize interface phrases
@ 2014-01-27 19:08 Benno Schulenberg
  2014-02-10 17:42 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: Benno Schulenberg @ 2014-01-27 19:08 UTC (permalink / raw)
  To: Util-Linux

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]


Hi,

When using the --debug option with hwclock, the phrase that denotes 
the interface being used isn't getting localized, because it isn't
gettextized.  Attached patch fixes this in a translator-friendly way: 
making the announcements into whole sentences.

Regards,

Benno

-- 
http://www.fastmail.fm - The professional email service


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-hwclock-internationalizing-the-message-of-the-used-i.patch --]
[-- Type: text/x-patch; name="0001-hwclock-internationalizing-the-message-of-the-used-i.patch", Size: 2220 bytes --]

From cff0a5a06e3a4e4bcdb6e32a1534ab0bb93ca04e Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg@justemail.net>
Date: Sun, 26 Jan 2014 22:32:15 +0100
Subject: [PATCH] hwclock: internationalizing the message of the used interface

In addition, do it in a single sentence instead of in two fragments.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
---
 sys-utils/hwclock-cmos.c |    2 +-
 sys-utils/hwclock-kd.c   |    2 +-
 sys-utils/hwclock-rtc.c  |    2 +-
 sys-utils/hwclock.c      |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sys-utils/hwclock-cmos.c b/sys-utils/hwclock-cmos.c
index 58b3ea5..7ffbf95 100644
--- a/sys-utils/hwclock-cmos.c
+++ b/sys-utils/hwclock-cmos.c
@@ -649,7 +649,7 @@ static int get_permissions_cmos(void)
 }
 
 static struct clock_ops cmos = {
-	"direct I/O instructions to ISA clock",
+	N_("Using direct I/O instructions to ISA clock."),
 	get_permissions_cmos,
 	read_hardware_clock_cmos,
 	set_hardware_clock_cmos,
diff --git a/sys-utils/hwclock-kd.c b/sys-utils/hwclock-kd.c
index 8e67009..3dac707 100644
--- a/sys-utils/hwclock-kd.c
+++ b/sys-utils/hwclock-kd.c
@@ -143,7 +143,7 @@ static int get_permissions_kd(void)
 }
 
 static struct clock_ops kd = {
-	"KDGHWCLK interface to m68k clock",
+	N_("Using the KDGHWCLK interface to m68k clock."),
 	get_permissions_kd,
 	read_hardware_clock_kd,
 	set_hardware_clock_kd,
diff --git a/sys-utils/hwclock-rtc.c b/sys-utils/hwclock-rtc.c
index a22ce4c..78f42aa 100644
--- a/sys-utils/hwclock-rtc.c
+++ b/sys-utils/hwclock-rtc.c
@@ -397,7 +397,7 @@ static int get_permissions_rtc(void)
 }
 
 static struct clock_ops rtc = {
-	"/dev interface to clock",
+	N_("Using the /dev interface to the clock."),
 	get_permissions_rtc,
 	read_hardware_clock_rtc,
 	set_hardware_clock_rtc,
diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index 5dd7919..30660d4 100644
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -1140,7 +1140,7 @@ static void determine_clock_access_method(const bool user_requests_ISA)
 
 	if (debug) {
 		if (ur)
-			printf(_("Using %s.\n"), ur->interface_name);
+			puts(_(ur->interface_name));
 		else
 			printf(_("No usable clock interface found.\n"));
 	}
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] hwclock: gettextize interface phrases
  2014-01-27 19:08 [patch] hwclock: gettextize interface phrases Benno Schulenberg
@ 2014-02-10 17:42 ` Karel Zak
  0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2014-02-10 17:42 UTC (permalink / raw)
  To: Benno Schulenberg; +Cc: Util-Linux

On Mon, Jan 27, 2014 at 08:08:31PM +0100, Benno Schulenberg wrote:
>  sys-utils/hwclock-cmos.c |    2 +-
>  sys-utils/hwclock-kd.c   |    2 +-
>  sys-utils/hwclock-rtc.c  |    2 +-
>  sys-utils/hwclock.c      |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

 Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-10 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-27 19:08 [patch] hwclock: gettextize interface phrases Benno Schulenberg
2014-02-10 17:42 ` Karel Zak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox