* bugs on exotic archs
@ 2014-05-12 18:45 Ruediger Meier
2014-05-13 8:23 ` Karel Zak
0 siblings, 1 reply; 8+ messages in thread
From: Ruediger Meier @ 2014-05-12 18:45 UTC (permalink / raw)
To: util-linux
Hi,
If somebody of you wants to do some sports...
Here I have a list of failing tests on certain architectures. If you own
such system you may want to confirm and fix the one or the other issue.
IMO most interesting are the fdisk failures on ppc and ppc64 and
utmpdump on aarch64 which are IMO real bugs. The other ones might be
bugs in the test suite or broken build hosts.
Failing test on certain archs:
%ifarch ppc ppc64
hexdump
fdisk/bsd
%endif
%ifarch ppc
fdisk/gpt
%endif
%ifarch armv6l armv7l aarch64
misc/setarch
%endif
%ifarch armv6l aarch64
fdisk/gpt
fdisk/oddinput
fdisk/sunlabel
misc/ionice
misc/swaplabel
kill/name
kill/print_pid
%endif
%ifarch aarch64
utmpdump
%endif
You can get the build logs and test diffs here
https://build.opensuse.org/package/show/home:rudi_m:branches:Base:System/util-linux
(The build status usually shows "success" because I've marked these
tests "known-fail" to be noticed when we would add more bugs.)
cu,
Rudi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bugs on exotic archs
2014-05-12 18:45 bugs on exotic archs Ruediger Meier
@ 2014-05-13 8:23 ` Karel Zak
2014-05-13 13:36 ` Ruediger Meier
2014-05-29 15:01 ` Ruediger Meier
0 siblings, 2 replies; 8+ messages in thread
From: Karel Zak @ 2014-05-13 8:23 UTC (permalink / raw)
To: Ruediger Meier; +Cc: util-linux
On Mon, May 12, 2014 at 08:45:18PM +0200, Ruediger Meier wrote:
> Hi,
>
> If somebody of you wants to do some sports...
>
> Here I have a list of failing tests on certain architectures. If you own
> such system you may want to confirm and fix the one or the other issue.
> IMO most interesting are the fdisk failures on ppc and ppc64 and
> utmpdump on aarch64 which are IMO real bugs. The other ones might be
> bugs in the test suite or broken build hosts.
>
> Failing test on certain archs:
>
> %ifarch ppc ppc64
> hexdump
this is not a bug, but the hexdump test disadvantage -- the output
may be different on big-endian if the output is composed from more input bytes.
> fdisk/bsd
BSD disklabel location depends on arch
> %endif
>
> %ifarch ppc
> fdisk/gpt
this is strange
> %endif
>
> %ifarch armv6l armv7l aarch64
> misc/setarch
setarch: armv7l: Unrecognized architecture
> %endif
>
> %ifarch armv6l aarch64
> fdisk/gpt
> fdisk/oddinput
> fdisk/sunlabel
Unsupported ioctl: cmd=0xffffffff801c0204 (1c)
> misc/ionice
qemu: Unsupported syscall: 314
ionice: ioprio_set failed: Function not implemented
> misc/swaplabel
Unsupported ioctl: cmd=0xffffffff801c0204 (1c)
> kill/name
> kill/print_pid
kill: cannot find process "naYZRDhfqEzs9bP".
> %endif
>
> %ifarch aarch64
> utmpdump
> %endif
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bugs on exotic archs
2014-05-13 8:23 ` Karel Zak
@ 2014-05-13 13:36 ` Ruediger Meier
2014-05-29 15:01 ` Ruediger Meier
1 sibling, 0 replies; 8+ messages in thread
From: Ruediger Meier @ 2014-05-13 13:36 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
On Tuesday 13 May 2014, Karel Zak wrote:
> On Mon, May 12, 2014 at 08:45:18PM +0200, Ruediger Meier wrote:
> > %ifarch ppc ppc64
> > hexdump
>
> this is not a bug, but the hexdump test disadvantage -- the output
> may be different on big-endian if the output is composed from more
> input bytes.
I've fixed the hexdump test partially
https://github.com/karelzak/util-linux/pull/76
cu,
Rudi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: bugs on exotic archs
2014-05-13 8:23 ` Karel Zak
2014-05-13 13:36 ` Ruediger Meier
@ 2014-05-29 15:01 ` Ruediger Meier
2014-05-29 15:25 ` [PATCH] tests: fix fdisk/bsd for big endian systems Ruediger Meier
1 sibling, 1 reply; 8+ messages in thread
From: Ruediger Meier @ 2014-05-29 15:01 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
On Tuesday 13 May 2014, Karel Zak wrote:
> On Mon, May 12, 2014 at 08:45:18PM +0200, Ruediger Meier wrote:
> > Failing test on certain archs:
> >
> > %ifarch ppc ppc64
> > hexdump
>
> this is not a bug, but the hexdump test disadvantage -- the output
> may be different on big-endian if the output is composed from more
> input bytes.
>
> > fdisk/bsd
>
> BSD disklabel location depends on arch
I'am going to fix these fdisk/bsd test md5sums for big endian.
Below I've added md5sum and hex diff of LE and BE images if
somebody want to check:
md5sum diff:
-------------------
rudi@gcc1-power7:~/devel/util-linux/build$ cat tests/diff/fdisk/bsd
--- /home/rudi/devel/util-linux/tests/expected/fdisk/bsd 2014-05-17 04:22:07.140999802 -0700
+++ /home/rudi/devel/util-linux/build/tests/output/fdisk/bsd 2014-05-29 07:39:26.715585544 -0700
@@ -50,7 +50,7 @@
-------------------
Create default BSD
-2e1cee529cb59c9341afef0443f196a1 bsd.img
+c2273b52976351db75596c47c10b0725 bsd.img
---layout----------
Welcome to fdisk <removed>.
@@ -79,7 +79,7 @@
Command (m for help):
-------------------
-b5c121c2091b2ff26b880551feac7112 bsd.img
+9a234a5b99e37d2ce0d92b65437b93cd bsd.img
---layout----------
Welcome to fdisk <removed>.
--------------------
hexdump diff 1, "2e1cee529cb59c9341afef0443f196a1 vs c2273b52976351db75596c47c10b0725":
-----------------------------
--- /tmp/bsd-le-1.img_ 2014-05-29 16:47:54.110684041 +0200
+++ /tmp/bsd-be-1.img_ 2014-05-29 16:47:54.040685344 +0200
@@ -7,19 +7,19 @@
000001f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 55 aa |..............U.|
00000200 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
-00200200 57 45 56 82 06 00 00 00 00 00 00 00 00 00 00 00 |WEV.............|
-00200210 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00200220 00 00 00 00 00 00 00 00 00 02 00 00 3f 00 00 00 |............?...|
-00200230 ff 00 00 00 01 00 00 00 c1 3e 00 00 c1 3e 00 00 |.........>...>..|
-00200240 00 00 00 00 00 00 00 00 10 0e 01 00 00 00 00 00 |................|
-00200250 00 00 00 00 00 00 00 00 20 00 00 00 00 00 00 00 |........ .......|
-00200260 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+00200040 82 56 45 57 00 06 00 00 00 00 00 00 00 00 00 00 |.VEW............|
+00200050 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+00200060 00 00 00 00 00 00 00 00 00 00 02 00 00 00 00 3f |...............?|
+00200070 00 00 00 ff 00 00 00 01 00 00 3e c1 00 00 3e c1 |..........>...>.|
+00200080 00 00 00 00 00 00 00 00 0e 10 00 01 00 00 00 00 |................|
+00200090 00 00 00 00 00 00 00 00 00 00 00 20 00 00 00 00 |........... ....|
+002000a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
-00200280 00 00 00 00 57 45 56 82 33 62 04 00 00 20 00 00 |....WEV.3b... ..|
-00200290 00 20 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |. ..............|
-002002a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-002002b0 00 00 00 00 00 40 00 00 00 10 00 00 00 00 00 00 |.....@..........|
-002002c0 00 00 00 00 c1 3e 00 00 00 00 00 00 00 00 00 00 |.....>..........|
-002002d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+002000c0 00 00 00 00 82 56 45 57 62 33 00 04 00 00 20 00 |.....VEWb3.... .|
+002000d0 00 00 20 00 00 00 00 00 00 00 00 00 00 00 00 00 |.. .............|
+002000e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+002000f0 00 00 00 00 00 00 40 00 00 00 10 00 00 00 00 00 |......@.........|
+00200100 00 00 00 00 00 00 3e c1 00 00 00 00 00 00 00 00 |......>.........|
+00200110 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00a00000
--------------------------
hexdump diff 1, "b5c121c2091b2ff26b880551feac7112 vs 9a234a5b99e37d2ce0d92b65437b93cd":
-----------------------------
--- /tmp/bsd-le-2.img_ 2014-05-29 16:47:54.147683353 +0200
+++ /tmp/bsd-be-2.img_ 2014-05-29 16:47:54.075684693 +0200
@@ -7,19 +7,19 @@
000001f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 55 aa |..............U.|
00000200 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
-00200200 57 45 56 82 06 00 00 00 00 00 00 00 00 00 00 00 |WEV.............|
-00200210 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-00200220 00 00 00 00 00 00 00 00 00 02 00 00 3f 00 00 00 |............?...|
-00200230 ff 00 00 00 01 00 00 00 c1 3e 00 00 c1 3e 00 00 |.........>...>..|
-00200240 00 00 00 00 00 00 00 00 10 0e 01 00 00 00 00 00 |................|
-00200250 00 00 00 00 00 00 00 00 20 00 00 00 00 00 00 00 |........ .......|
-00200260 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+00200040 82 56 45 57 00 06 00 00 00 00 00 00 00 00 00 00 |.VEW............|
+00200050 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+00200060 00 00 00 00 00 00 00 00 00 00 02 00 00 00 00 3f |...............?|
+00200070 00 00 00 ff 00 00 00 01 00 00 3e c1 00 00 3e c1 |..........>...>.|
+00200080 00 00 00 00 00 00 00 00 0e 10 00 01 00 00 00 00 |................|
+00200090 00 00 00 00 00 00 00 00 00 00 00 20 00 00 00 00 |........... ....|
+002000a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
-00200280 00 00 00 00 57 45 56 82 35 7a 04 00 00 20 00 00 |....WEV.5z... ..|
-00200290 00 20 00 00 01 08 00 00 00 10 00 00 00 00 00 00 |. ..............|
-002002a0 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
-002002b0 00 00 00 00 00 40 00 00 00 10 00 00 00 00 00 00 |.....@..........|
-002002c0 00 00 00 00 c1 3e 00 00 00 00 00 00 00 00 00 00 |.....>..........|
-002002d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+002000c0 00 00 00 00 82 56 45 57 7d 32 00 04 00 00 20 00 |.....VEW}2.... .|
+002000d0 00 00 20 00 00 00 08 01 00 00 10 00 00 00 00 00 |.. .............|
+002000e0 07 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
+002000f0 00 00 00 00 00 00 40 00 00 00 10 00 00 00 00 00 |......@.........|
+00200100 00 00 00 00 00 00 3e c1 00 00 00 00 00 00 00 00 |......>.........|
+00200110 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00a00000
-------------------------
cu,
Rudi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] tests: fix fdisk/bsd for big endian systems
2014-05-29 15:01 ` Ruediger Meier
@ 2014-05-29 15:25 ` Ruediger Meier
2014-05-29 17:32 ` Ruediger Meier
2014-05-29 17:52 ` Ruediger Meier
0 siblings, 2 replies; 8+ messages in thread
From: Ruediger Meier @ 2014-05-29 15:25 UTC (permalink / raw)
To: util-linux
From: Ruediger Meier <ruediger.meier@ga-group.nl>
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
---
tests/ts/fdisk/bsd | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/ts/fdisk/bsd b/tests/ts/fdisk/bsd
index 7e3c787..32b3f31 100755
--- a/tests/ts/fdisk/bsd
+++ b/tests/ts/fdisk/bsd
@@ -39,6 +39,17 @@ FDISK_CMD_BSD_LIST_TYPES="b\nl\nq\n" # list supported PT types and quit
#set -x
+# BSD disklabel depends on endianess
+BYTE_ORDER=$($TS_HELPER_SYSINFO byte-order)
+function fdisk_bsd_byte_order_clean
+{
+ [ $BYTE_ORDER = "BE" ] || return
+ sed -i \
+ -e s/2e1cee529cb59c9341afef0443f196a1/c2273b52976351db75596c47c10b0725/\
+ -e s/b5c121c2091b2ff26b880551feac7112/9a234a5b99e37d2ce0d92b65437b93cd/\
+ "$TS_OUTPUT"
+}
+
function print_layout {
echo -ne "\n---layout----------" >> $TS_OUTPUT
$TS_CMD_FDISK -l ${TEST_IMAGE_NAME} >> $TS_OUTPUT
@@ -102,5 +113,6 @@ echo -e "${FDISK_CMD_BSD_LIST_TYPES}" | \
$TS_CMD_FDISK ${TEST_IMAGE_NAME} | \
sed 's/Reading .*//g; s/Welcome to fdisk .*//' >> $TS_OUTPUT 2>&1
+fdisk_bsd_byte_order_clean
ts_fdisk_clean ${TEST_IMAGE_NAME}
ts_finalize
--
1.8.4.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tests: fix fdisk/bsd for big endian systems
2014-05-29 15:25 ` [PATCH] tests: fix fdisk/bsd for big endian systems Ruediger Meier
@ 2014-05-29 17:32 ` Ruediger Meier
2014-05-29 17:52 ` Ruediger Meier
1 sibling, 0 replies; 8+ messages in thread
From: Ruediger Meier @ 2014-05-29 17:32 UTC (permalink / raw)
To: util-linux
On Thursday 29 May 2014, Ruediger Meier wrote:
> From: Ruediger Meier <ruediger.meier@ga-group.nl>
>
> Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
> ---
> tests/ts/fdisk/bsd | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/ts/fdisk/bsd b/tests/ts/fdisk/bsd
> index 7e3c787..32b3f31 100755
> --- a/tests/ts/fdisk/bsd
> +++ b/tests/ts/fdisk/bsd
> @@ -39,6 +39,17 @@ FDISK_CMD_BSD_LIST_TYPES="b\nl\nq\n" # list supported PT types and quit
>
> #set -x
>
> +# BSD disklabel depends on endianess
> +BYTE_ORDER=$($TS_HELPER_SYSINFO byte-order)
> +function fdisk_bsd_byte_order_clean
> +{
> + [ $BYTE_ORDER = "BE" ] || return
> + sed -i \
> + -e s/2e1cee529cb59c9341afef0443f196a1/c2273b52976351db75596c47c10b0725/\
> + -e s/b5c121c2091b2ff26b880551feac7112/9a234a5b99e37d2ce0d92b65437b93cd/\
Argh, I have screwed it.
> + "$TS_OUTPUT"
> +}
> +
> function print_layout {
> echo -ne "\n---layout----------" >> $TS_OUTPUT
> $TS_CMD_FDISK -l ${TEST_IMAGE_NAME} >> $TS_OUTPUT
> @@ -102,5 +113,6 @@ echo -e "${FDISK_CMD_BSD_LIST_TYPES}" | \
> $TS_CMD_FDISK ${TEST_IMAGE_NAME} | \
> sed 's/Reading .*//g; s/Welcome to fdisk .*//' >> $TS_OUTPUT 2>&1
>
> +fdisk_bsd_byte_order_clean
> ts_fdisk_clean ${TEST_IMAGE_NAME}
> ts_finalize
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] tests: fix fdisk/bsd for big endian systems
2014-05-29 15:25 ` [PATCH] tests: fix fdisk/bsd for big endian systems Ruediger Meier
2014-05-29 17:32 ` Ruediger Meier
@ 2014-05-29 17:52 ` Ruediger Meier
2014-06-09 11:02 ` Karel Zak
1 sibling, 1 reply; 8+ messages in thread
From: Ruediger Meier @ 2014-05-29 17:52 UTC (permalink / raw)
To: util-linux
From: Ruediger Meier <ruediger.meier@ga-group.nl>
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
---
tests/ts/fdisk/bsd | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/ts/fdisk/bsd b/tests/ts/fdisk/bsd
index 7e3c787..be44b63 100755
--- a/tests/ts/fdisk/bsd
+++ b/tests/ts/fdisk/bsd
@@ -39,6 +39,17 @@ FDISK_CMD_BSD_LIST_TYPES="b\nl\nq\n" # list supported PT types and quit
#set -x
+# BSD disklabel depends on endianess
+BYTE_ORDER=$($TS_HELPER_SYSINFO byte-order)
+function fdisk_bsd_byte_order_clean
+{
+ [ $BYTE_ORDER = "BE" ] || return
+ sed -i \
+ -e "s/c2273b52976351db75596c47c10b0725/2e1cee529cb59c9341afef0443f196a1/" \
+ -e "s/9a234a5b99e37d2ce0d92b65437b93cd/b5c121c2091b2ff26b880551feac7112/" \
+ "$TS_OUTPUT"
+}
+
function print_layout {
echo -ne "\n---layout----------" >> $TS_OUTPUT
$TS_CMD_FDISK -l ${TEST_IMAGE_NAME} >> $TS_OUTPUT
@@ -102,5 +113,6 @@ echo -e "${FDISK_CMD_BSD_LIST_TYPES}" | \
$TS_CMD_FDISK ${TEST_IMAGE_NAME} | \
sed 's/Reading .*//g; s/Welcome to fdisk .*//' >> $TS_OUTPUT 2>&1
+fdisk_bsd_byte_order_clean
ts_fdisk_clean ${TEST_IMAGE_NAME}
ts_finalize
--
1.8.4.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tests: fix fdisk/bsd for big endian systems
2014-05-29 17:52 ` Ruediger Meier
@ 2014-06-09 11:02 ` Karel Zak
0 siblings, 0 replies; 8+ messages in thread
From: Karel Zak @ 2014-06-09 11:02 UTC (permalink / raw)
To: Ruediger Meier; +Cc: util-linux
On Thu, May 29, 2014 at 07:52:52PM +0200, Ruediger Meier wrote:
> tests/ts/fdisk/bsd | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-09 11:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 18:45 bugs on exotic archs Ruediger Meier
2014-05-13 8:23 ` Karel Zak
2014-05-13 13:36 ` Ruediger Meier
2014-05-29 15:01 ` Ruediger Meier
2014-05-29 15:25 ` [PATCH] tests: fix fdisk/bsd for big endian systems Ruediger Meier
2014-05-29 17:32 ` Ruediger Meier
2014-05-29 17:52 ` Ruediger Meier
2014-06-09 11:02 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox