[PATCH] Link mkswap to mkfs.swap so mkfs -t swap works

[PATCH] Link mkswap to mkfs.swap so mkfs -t swap works

[Josh Triplett]

This makes it easier to write generic code that deals with swap
along with other filesystems.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 disk-utils/Makemodule.am | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/disk-utils/Makemodule.am b/disk-utils/Makemodule.am
index 995e085..3f8f96b 100644
--- a/disk-utils/Makemodule.am
+++ b/disk-utils/Makemodule.am
@@ -59,6 +59,16 @@ endif
 if HAVE_SELINUX
 mkswap_LDADD += -lselinux
 endif
+
+install-exec-hook-mkswap:
+	ln -sf mkswap $(DESTDIR)$(sbindir)/mkfs.swap
+
+uninstall-hook-mkswap:
+	rm -f $(DESTDIR)$(sbindir)/mkfs.swap
+
+INSTALL_EXEC_HOOKS += install-exec-hook-mkswap
+UNINSTALL_HOOKS += uninstall-hook-mkswap
+
 endif # BUILD_MKSWAP
 
 
-- 
2.0.1

Re: [PATCH] Link mkswap to mkfs.swap so mkfs -t swap works

[Karel Zak]

On Sun, Aug 03, 2014 at 11:48:14AM -0700, Josh Triplett wrote:
> This makes it easier to write generic code that deals with swap
> along with other filesystems.

 Hmm... mkfs wrapper is deprecated, it does not provide any
 functionality and it seems better when people use directly the FS
 specific tools to create filesystems.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH] Link mkswap to mkfs.swap so mkfs -t swap works

[josh]

On Wed, Aug 06, 2014 at 03:31:03PM +0200, Karel Zak wrote:
> On Sun, Aug 03, 2014 at 11:48:14AM -0700, Josh Triplett wrote:
> > This makes it easier to write generic code that deals with swap
> > along with other filesystems.
> 
>  Hmm... mkfs wrapper is deprecated, it does not provide any
>  functionality and it seems better when people use directly the FS
>  specific tools to create filesystems.

I've come across more than one script that takes a table of partition
sizes/proportions and filesystem types, creates the partitions, and
calls mkfs with the filesystem type.

Some of those scripts directly call mkfs.$type instead, rather than
mkfs -t $type, but either way this change would eliminate a special-case
for swap.

- Josh Triplett