From: Karel Zak <kzak@redhat.com>
To: Will Johansson <will.johansson@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: login-utils: Enable building util-linux against OpenPAM
Date: Mon, 15 Dec 2014 10:19:31 +0100 [thread overview]
Message-ID: <20141215091931.GW19904@x2.net.home> (raw)
In-Reply-To: <1418179231-21326-1-git-send-email-will.johansson@gmail.com>
On Tue, Dec 09, 2014 at 06:40:30PM -0800, Will Johansson wrote:
> I recently experimented with cross-compiling for embedded devices, and
> sought to try out util-linux with OpenPAM instead of Linux-PAM because
> OpenPAM was simpler to cross-compile. Unfortunately for me, it did not
> work out of the box, so I decided to try to patch util-linux to support
> compiling against OpenPAM. Turned out to be a fairly simple exercise.
>
> This is the fruit of my efforts. There is a caveat, which I will
Applied, thanks.
> be happy to address if it's a problem. The patch's configuration does
> not support building if you happen to have both Linux-PAM and OpenPAM
> in your build paths. I could update it to prefer Linux-PAM by default.
> I'm not sure how it'd would work if OpenPAM libraries is also in the
> search path, as -lpam is used by both Linux-PAM and OpenPAM (probably
> undefined behavior).
>
> Either way, it should compile fine against Linux-PAM and OpenPAM.
> There are some unused variables in login.c, but seems to have to do
> with _HAVE_UT_TV, which is not the case in my configuration. I'm
> more than happy to provide a separate patch to wrap the unused
> variables with an #ifdef _HAVE_UT_TV.
I don't have OpenPAM, so I'm not able to verify usability, but it
would be nice to have build without warnings.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-12-15 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 2:40 login-utils: Enable building util-linux against OpenPAM Will Johansson
2014-12-10 2:40 ` [PATCH] " Will Johansson
2014-12-15 9:19 ` Karel Zak [this message]
2014-12-15 11:45 ` Will Johansson
2014-12-15 11:46 ` Will Johansson
2014-12-15 12:47 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215091931.GW19904@x2.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=will.johansson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox