From: Karel Zak <kzak@redhat.com>
To: Will Johansson <will.johansson@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: login-utils: Enable building util-linux against OpenPAM
Date: Mon, 15 Dec 2014 13:47:35 +0100 [thread overview]
Message-ID: <20141215124735.GB19904@x2.net.home> (raw)
In-Reply-To: <CAE83jyxVG_CKR6rzmdO==rJB7aA8kWasXvXyK_PW8C6SAbzLAg@mail.gmail.com>
On Mon, Dec 15, 2014 at 03:46:55AM -0800, Will Johansson wrote:
> Hi Karel,
>
> Thanks for applying. I have a small patch for _HAVE_UT_TV incoming in
> a few minutes.
>
> Turns out it was because musl-libc doesn't define _HAVE_UT_TV, even
> though musl-libc's utmp struct does have a ut_tv field. There are two
> options: 1.) I could patch upstream musl-libc to define _HAVE_UT_TV or
> 2.) detect musl-libc somehow. I think I prefer the first option.
Well, you have to care about already released musl-libc -- it's easy to detect
that by AC_CHECK_MEMBERS() in configure.ac. It would be nice to fix
the problem in util-linux code independently on your item 1).
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2014-12-15 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 2:40 login-utils: Enable building util-linux against OpenPAM Will Johansson
2014-12-10 2:40 ` [PATCH] " Will Johansson
2014-12-15 9:19 ` Karel Zak
2014-12-15 11:45 ` Will Johansson
2014-12-15 11:46 ` Will Johansson
2014-12-15 12:47 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215124735.GB19904@x2.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=will.johansson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox