[bug] logger 2.26: regression, option -i not combinable with other options

[bug] logger 2.26: regression, option -i not combinable with other options

[Juergen Daubert]

Hello,

with logger from util-linux 2.25.x it's possible to combine the option
-i with other options like:

 logger -is

with 2.26 I get the following error message:

 $:~> logger -is
 logger: failed to parse id: 's'

The changed behaviour breaks existing scripts like dhcpcd-run-hooks [1]
from dhcpcd [2].


Posible solution:
- don't combine the -i and --id options but keep the behaviour of -i and
  make --id a long-form only option. 


Thanks and best regards
Juergen


[1] http://roy.marples.name/projects/dhcpcd/artifact/953bd27
[2] http://roy.marples.name/projects/dhcpcd/index

Re: [bug] logger 2.26: regression, option -i not combinable with other options

[Karel Zak]

On Fri, Feb 20, 2015 at 11:06:47AM +0100, Juergen Daubert wrote:
> with logger from util-linux 2.25.x it's possible to combine the option
> -i with other options like:
> 
>  logger -is
> 
> with 2.26 I get the following error message:
> 
>  $:~> logger -is
>  logger: failed to parse id: 's'
> 
> The changed behaviour breaks existing scripts like dhcpcd-run-hooks [1]
> from dhcpcd [2].

Hmm... stupid regression, next time it would be probably better to
introduce optional arguments for long options only.

Anyway, always use long options in scripts. It's more robust and more
readable.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [bug] logger 2.26: regression, option -i not combinable with other options

[Juergen Daubert]

On Fri, Feb 20, 2015 at 11:41:06AM +0100, Karel Zak wrote:
> On Fri, Feb 20, 2015 at 11:06:47AM +0100, Juergen Daubert wrote:
> > with logger from util-linux 2.25.x it's possible to combine the option
> > -i with other options like:
> > 
> >  logger -is
> > 
> > with 2.26 I get the following error message:
> > 
> >  $:~> logger -is
> >  logger: failed to parse id: 's'
> > 
> > The changed behaviour breaks existing scripts like dhcpcd-run-hooks [1]
> > from dhcpcd [2].
> 
> Hmm... stupid regression, next time it would be probably better to
> introduce optional arguments for long options only.
> 
> Anyway, always use long options in scripts. It's more robust and more
> readable.

here's the response from dhcpcd's author:

 The original BSD sources from which logger is clearly based don't support
 long options .... and dhcpcd needs to work with them. 


Greetings
Juergen

Re: [bug] logger 2.26: regression, option -i not combinable with other options

[Sami Kerola]

On 20 February 2015 at 12:44, Juergen Daubert <jue@jue.li> wrote:
> On Fri, Feb 20, 2015 at 11:41:06AM +0100, Karel Zak wrote:
>> On Fri, Feb 20, 2015 at 11:06:47AM +0100, Juergen Daubert wrote:
>> > with logger from util-linux 2.25.x it's possible to combine the option
>> > -i with other options like:
>> >
>> >  logger -is
>> >
>> > with 2.26 I get the following error message:
>> >
>> >  $:~> logger -is
>> >  logger: failed to parse id: 's'
>> >
>> > The changed behaviour breaks existing scripts like dhcpcd-run-hooks [1]
>> > from dhcpcd [2].
>>
>> Hmm... stupid regression, next time it would be probably better to
>> introduce optional arguments for long options only.

I agree about both; stupid regression and the --id should not be mixed
with -i option.

>> Anyway, always use long options in scripts. It's more robust and more
>> readable.
>
> here's the response from dhcpcd's author:
>
>  The original BSD sources from which logger is clearly based don't support
>  long options .... and dhcpcd needs to work with them.

Technically speaking assigning short options is against POSIX.

http://pubs.opengroup.org/onlinepubs/9699919799/utilities/logger.html

But removing short options would be so user unfriendly that proposing
such change would lead to immediate tosspot of the year nomination.
Clearly the 'logger -is' should keep on working the same way it always
has. Here's my proposal how regression could be fixed.

https://github.com/kerolasa/lelux-utiliteetit/commit/bfe6c5d2381b510a4a0330c1c809a63e49b26840

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: [bug] logger 2.26: regression, option -i not combinable with other options

[Benno Schulenberg]

On Fri, Feb 20, 2015, at 21:12, Sami Kerola wrote:
> Clearly the 'logger -is' should keep on working the same way it always
> has. Here's my proposal how regression could be fixed.
> 
> https://github.com/kerolasa/lelux-utiliteetit/commit/bfe6c5d2381b510a4a0330c1c809a63e49b26840

The fix looks fine, of course.  Just about the commit message:

s/loggerit's/logger it's/
s/options such as:/options, such as -s.  But currently:/

Also, to make the fix complete the -i and -id options have
to be separated in the usage text and the man page.

Benno

-- 
http://www.fastmail.com - Does exactly what it says on the tin

Re: [bug] logger 2.26: regression, option -i not combinable with other options

[Sami Kerola]

On 21 February 2015 at 11:37, Benno Schulenberg <bensberg@justemail.net> wrote:
> On Fri, Feb 20, 2015, at 21:12, Sami Kerola wrote:
>> Clearly the 'logger -is' should keep on working the same way it always
>> has. Here's my proposal how regression could be fixed.
>>
>> https://github.com/kerolasa/lelux-utiliteetit/commit/bfe6c5d2381b510a4a0330c1c809a63e49b26840
>
> The fix looks fine, of course.  Just about the commit message:
>
> s/loggerit's/logger it's/
> s/options such as:/options, such as -s.  But currently:/
>
> Also, to make the fix complete the -i and -id options have
> to be separated in the usage text and the man page.

Cheers Benno,

Improvements you mentioned are included in

https://github.com/kerolasa/lelux-utiliteetit/commit/87a34e69ff79ef5c2b81cee33902885e2255ac39

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: [bug] logger 2.26: regression, option -i not combinable with other options

[Karel Zak]

On Fri, Feb 20, 2015 at 11:06:47AM +0100, Juergen Daubert wrote:
> Hello,
> 
> with logger from util-linux 2.25.x it's possible to combine the option
> -i with other options like:
> 
>  logger -is
> 
> with 2.26 I get the following error message:
> 
>  $:~> logger -is
>  logger: failed to parse id: 's'
> 
> The changed behaviour breaks existing scripts like dhcpcd-run-hooks [1]
> from dhcpcd [2].

 Fixed in git tree, the bugfix will be in v2.26.1 (probably last week
 this month or early).

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com