Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: util-linux@vger.kernel.org
Subject: question about hardcoded binary paths (swapon / mkswap)
Date: Wed, 1 Apr 2015 13:42:56 +0200	[thread overview]
Message-ID: <201504011342.56546.sweet_f_a@gmx.de> (raw)

Hi,

I wonder about some hardcoded binary paths.

Example swapon.c:

#define PATH_MKSWAP    "/sbin/mkswap"

There are a two problems.
1. It's wrong. We should use $sbindir from configure.
2. When called from our test-suite it will use a wrong (or
   non-existend, broken) binary. This happens in test swapon/fixpgsz.

The question is how to fix this.

I would prefer to use "mkwsap" from the same directory like swapon or to 
simply execvp "mkswap" from PATH. But don't know if we want this. If we 
really want to keep a hardcoded sbindir then we would need "#ifdef 
TEST_PROGRAM".

Any comments?

cu,
Rudi

             reply	other threads:[~2015-04-01 11:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 11:42 Ruediger Meier [this message]
2015-04-01 13:38 ` question about hardcoded binary paths (swapon / mkswap) Isaac Dunham
2015-04-01 16:17   ` Ruediger Meier
2015-04-01 20:10     ` Mike Frysinger
2015-04-01 21:06       ` Ruediger Meier
2015-04-01 21:38         ` Karel Zak
2015-04-02  1:12           ` Mike Frysinger
2015-04-02  8:20             ` Karel Zak
2015-04-02 16:19               ` Mike Frysinger
2015-04-02 19:15                 ` Karel Zak
2015-04-02 22:50                   ` Ruediger Meier
2015-04-03  1:15                   ` Mike Frysinger
2015-04-03  8:52                     ` Karel Zak
2015-04-03 23:16                       ` Mike Frysinger
2015-04-02 17:28               ` Isaac Dunham
2015-04-01 22:23         ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504011342.56546.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox